WIP: ENH: Relative dose representation for isolevels

SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.

https://slicerrt.org

126 stars 60 forks source link

WIP: ENH: Relative dose representation for isolevels #168

Closed MichaelColonel closed 3 years ago

MichaelColonel commented 3 years ago

Here is my understanding of relative dose isolevels, possible solution for #36, #96.

If RTDOSE type is "GY" then clicking on "Percentage dose isolevels" check box you can switch between absolute and relative isolevels representation. If RTDOSE type is "RELATIVE" then only relative representation is available.

Screenshot as an example:

cpinter commented 3 years ago

Not quite sure what is the problem with levels table? Do you want to get rid of it entirely?

No, obviously not. But from your screenshot it seems that you have a new collapsible button within the Input section. The problem with that button is that it's not obvious where that section ends, and that it is unusual to have a collapsible button within another collapsible button. I suggest reorganizing the UI so that it is less confusing. Maybe instead of a collapsible button, you could put the "Prescribed or reference dose value" in a groupbox, but other solutions could work too.

MichaelColonel commented 3 years ago

Maybe instead of a collapsible button, you could put the "Prescribed or reference dose value" in a groupbox, but other solutions could work too.

I've changed UI a little with some other fixes.

cpinter commented 3 years ago

I like this much better, thank you!

@lassoan @gregsharp do you have anything to add? If not then I'll merge this on or after the weekend.