ENH: Update DRR RT Beam parameters from 3D camera node

SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.

https://slicerrt.org

126 stars 60 forks source link

ENH: Update DRR RT Beam parameters from 3D camera node #187

Closed MichaelColonel closed 3 years ago

MichaelColonel commented 3 years ago

Direction cosines of vtkCamera are used to calculate a new beam transform.

Updated beam parameters from 3D camera are:

Gantry Angle;
Patient Support Rotation (Couch) Angle;
Source-Axis Distance.

Minor change in onBeamsEyeViewButtonClicked method of RoomsEyeView module GUI.

cpinter commented 3 years ago

Thanks for the new contribution! This week I won't have time to review the code, so it would help a lot if you added a detailed description in the commit message. Or if someone can find the time to review this it would be welcome @Sunderlandkyl @gregsharp @lassoan . Thanks!

MichaelColonel commented 3 years ago

I've added a more detailed description into commit message.

cpinter commented 3 years ago

Thanks, I'm OK with merging this. It seems to be low-risk because it is an additional feature, and quite a nice one too.

Please make sure no new tests fail and confirm.

I'll give a little time for the others mentioned above to take a look if they want.

MichaelColonel commented 3 years ago

Failed tests under linux: 1:qSlicerBeamsModuleGenericTest 2:qSlicerBeamsModuleWidgetGenericTest 6:vtkSlicerIsodoseModuleLogicTest_EclipseProstate 39:vtkSlicerSegmentComparisonModuleLogicTest_EclipseProstate_Transformed 47:py_nomainwindow_PlmProtonDoseEngineTest

Sunderlandkyl commented 3 years ago

The changes look good to me.