search

SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.
https://slicerrt.org
126 stars 60 forks source link

BUG: Make absolute isodose color table node available for editing #199

Closed MichaelColonel closed 2 years ago

MichaelColonel commented 2 years ago

Possible fix for a bug in discussion: https://discourse.slicer.org/t/isodose-generation/20115

MichaelColonel commented 2 years ago

I have changed logic, so a default isodose (absolute dose) color node is copied at the beginning, so absolute isodose color table node is available to editing.

I think the PR is ready for a review.

cpinter commented 2 years ago

Thanks for the implementation! I added some comments. In general if this works like this, then I think that the workaround of making copies of the color node so that it's editable is a reasonable solution.

jingyangxie commented 2 years ago

Thank you so much for your effort! May I know when the new version will be available?

cpinter commented 2 years ago

@MichaelColonel Almost perfect, just one minor request to remove commented code. I'll merge it afterwards.

@jingyangxie The day following the integration.

jingyangxie commented 2 years ago

@cpinter Thanks for your information!

cpinter commented 2 years ago

@MichaelColonel Thank you once again for the contribution!

@jingyangxie Please download the Slicer Preview version tomorrow and install SlicerRT. It should contain Mikhail's fix.

jingyangxie commented 2 years ago

@MichaelColonel @cpinter Thanks Michael and Csaba. I really appreciate your kind support!