SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.
https://slicerrt.org
128 stars 60 forks source link

ENH: Markups plane node for imager and image window #204

Closed MichaelColonel closed 2 years ago

MichaelColonel commented 2 years ago

DRR important updates:

  1. First commit updates visualization of DRR imager and image sub-window from closed curve to plane node, because it's much better to understand.
  2. Second commit makes observation of reference beam node. DRR geometry and transformation parameters such as View-Up and normal vectors are updated if reference beam node transformation or geometry was updated.
  3. Use CT data from SampleData module in DRR python test.
MichaelColonel commented 2 years ago

Some updates for DRR computation.

MichaelColonel commented 2 years ago
  • Are there any new tests failing?

The http://slicer.kitware.com/midas3 site is no longer available. Tests can't download the data anymore, that is why some python tests are failing recently. DRR test uses the CTChest sample data anyway, now it's just a build-in data in the 3D Slicer.

MichaelColonel commented 2 years ago
  • What is the behavior when loading a scene that uses the old curve nodes?

Major difference is a visual representation, everything else is the same. Before is a closed curve markups. After is a new plane markups. Plane markups is better (IMHO). image

Sunderlandkyl commented 2 years ago

Thanks, it looks good to me.