SlicerRt / SlicerRT

Open-source toolkit for radiation therapy research, an extension of 3D Slicer. Features include DICOM-RT import/export, dose volume histogram, dose accumulation, external beam planning (TPS), structure comparison and morphology, isodose line/surface generation, etc.
https://slicerrt.org
124 stars 60 forks source link

ENH: GUI upgrade of perspective projection calculation: #222

Closed MichaelColonel closed 1 year ago

MichaelColonel commented 1 year ago
MichaelColonel commented 1 year ago

New interface

image

cpinter commented 1 year ago

After a very quick glance it looks OK to me. One question so far: was there a specific reason for removing ModuleWindowInitialized? Thanks!

MichaelColonel commented 1 year ago

Module is quite simple and it doesn't require any specific GUI initiation. The GUI doesn't show beam node correctly if parameterNode was created in python console if you switch into module GUI for the first time with ModuleWindowInitialized.

cpinter commented 1 year ago

Makes sense, thanks! I won't be able to do a thorough review, but since you are the main user/developer of the DRR module I'd simply accept this change. @Sunderlandkyl @lassoan please review if interested. I'll merge it in a day or two (unless you need it merged asap @MichaelColonel in which case I can do it now). Thanks again!

MichaelColonel commented 1 year ago

I thick it could be merged, so it could be tested by the user.

lassoan commented 1 year ago

Thank you for all your hard work.