SlideRuleEarth / sliderule

Server and client framework for on-demand science data processing in the cloud
https://slideruleearth.io
Other
26 stars 11 forks source link

`atl06` and `atl06p` broken for longitudes outside -150,150 #341

Open jpswinski opened 9 months ago

jpswinski commented 9 months ago

The logic to process the LSF when photons are outside -150 and 150 degrees longitude is broken. This was reported by a user and confirmed by the development team.

jpswinski commented 9 months ago

This is a regression that was introduced in v4.0.0 as a result of reworking the Atl06Dispatch code.

jpswinski commented 9 months ago

https://github.com/ICESat2-SlideRule/sliderule/blob/4529a12ba2016029c927e3d469a9ac7111362c13/plugins/icesat2/plugin/Atl06Dispatch.cpp#L793-L823

The shift of the latitude is affecting the wrong variable.

jpswinski commented 9 months ago

v4.0.2 should fix the problem. Keeping this issue open until further testing is performed. See 3b535c588f9fa3c54e0f4ab86ea223c5f8463c23