Closed jpswinski closed 11 months ago
I reviewed the code. I also ran my performance tests. I found no issues. I committed a minor change, almost cosmetic. Class member functions implemented in header file are implicitly inlined. The 'inline' keyword is redundant. I removed it from a few header files.
Major rework of the code to bring it up to clang-tidy and cppcheck standards. Current code in this branch:
config-debug
), and fails the build on any warningconfig-debug
)config-debug
)const char*
wrapper in StringLib called FString. SafeString only exists now in theatlas
plugin. All string manipulation should first try to use std::string, then FString, and then StringLib with aconst char*
if nothing else is a good fit.List
,Dictionary
,Ordering
,Table
, have been updated so that if they are provided a pointer they automatically manage the memory. The managed versions (e.g.MgList
, etc.) have been done away with. If any of these data structures contains a pointer type, the object being pointed to will be automatically deleted by the data structure when necessary. Another way to think of this is thatadd
ing a member to one of these containers always transfers ownership.