search

SlideRuleEarth / sliderule

Server and client framework for on-demand science data processing in the cloud
https://slideruleearth.io
Other
26 stars 11 forks source link

"pflags" variable in SR output giving wrong values #357

Closed slhowardESR closed 6 months ago

slhowardESR commented 8 months ago

The pflags variable seems to have the wrong values in it.

pflags should have values like:
pflags Size: 503586x1 Dimensions: delta_time Datatype: double Attributes: long_name = 'Processing Flags' flag_values = **[0 1 2 4]** flag_meanings = 'valid, spread too short, too few photons, max iterations reached' valid_min = 0 valid_max = 4 coordinates = 'latitude longitude'

But instead, when I read the output file, I get: pflag

This is true in both netcdf and parquet files read in matlab. (and it happens on both the released version, and the current main development branch. And it is true for the tracks I have looked at .

I processed a small area at the end of Sept (with a current released version I think), and the pflags in that version were correct.

Let me know if you need more info.

jpswinski commented 7 months ago

@slhowardESR - thanks for bringing this to our attention. Those pflag values look very wrong. I am going to have to try to recreate this because nothing is jumping out in the code that would cause this behavior.

jpswinski commented 7 months ago

Turns out I introduced the bug into the code when making some changes to the atl06 code - the pflag variable was no longer being initialized and as a result, it was starting with garbage values before having the different flags OR'ed in. I've made the fix and rebuilt the docker image. You should be good to go with the esr cluster.