search

SlightlyMad / VolumetricLights

Volumetric Lights for Unity
BSD 3-Clause "New" or "Revised" License
2.05k stars 304 forks source link

Error in Unity 2017.1.1p4 #24

Open lucasmontec opened 7 years ago

lucasmontec commented 7 years ago

Invalid pass number (1) for Graphics.Blit (Material "Hidden/BilateralBlur" with 1 passes) UnityEngine.Graphics:Blit(Texture, RenderTexture, Material, Int32) VolumetricLightRenderer:OnRenderImage(RenderTexture, RenderTexture) (at Assets/VolumetricLights/Scripts/VolumetricLightRenderer.cs:354)

opstal-thomas commented 7 years ago

Having the same issue in Unity 2017.1.2f1.

lucasmontec commented 7 years ago

Also, the game some times is rendered either pink or black.

SlightlyMad commented 7 years ago

Sorry guys for the late reply. I'm super busy. Did you figure it out? It is some weird Unity import issue. Manually reimporting the shaders should fix it.

lucasmontec commented 6 years ago

I'll try it out. For now I have disabled the asset. Anyway, thanks! I'll try that. Sorry for the delay.

2017-10-29 17:23 GMT-02:00 Michal Skalsky notifications@github.com:

Sorry guys for the late reply. I'm super busy. Did you figure it out? It is some weird Unity import issue. Manually reimporting the shaders should fix it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SlightlyMad/VolumetricLights/issues/24#issuecomment-340287164, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUb_V4q-tUr2RTHftOp8Wi1gwyZTkSIks5sxNDIgaJpZM4Px2ys .

-- Lucas Montenegro Carvalhaes

May the sawce be with you

gregcotten commented 6 years ago

@SlightlyMad Seems like it might be a Metal issue. It runs fine in the editor (2017.3.0f3), but when I build I get the same error with BilateralBlur. I can fix the problem by removing Metal from the Graphics API. I do this by going to Edit->Project Settings->Player, go to "Other Settings", Uncheck "Auto Graphics API for Mac", and remove Metal from the list.

My exact error:


Invalid pass number (1) for Graphics.Blit (Material "Hidden/BilateralBlur" with 1 passes)
UnityEngine.Graphics:INTERNAL_CALL_Internal_BlitMaterial(Texture, RenderTexture, Material, Int32, Boolean, Vector2&, Vector2&)
UnityEngine.Graphics:Internal_BlitMaterial(Texture, RenderTexture, Material, Int32, Boolean, Vector2, Vector2)
UnityEngine.Graphics:Blit(Texture, RenderTexture, Material, Int32)
VolumetricLightRenderer:OnRenderImage(RenderTexture, RenderTexture) (at [path-to-project]/Assets/Vendor/Volumetric Lighting Assets/Scripts/VolumetricLightRenderer.cs:363)
gregcotten commented 6 years ago

Looks like #18 has a similar issue with BilateralBlur on Android. I also saw somewhere that someone with a PS4 build target had this problem. I wonder what the issue is?

SlightlyMad commented 6 years ago

@gregcotten the error simply means that the shaders didn't compile. it is probably different problem on different platforms. the only "officially" supported platforms are directx and opengl. i would fix ps4 and metal but i don't have mac or ps4 devkit. and so it is impossible for me to guess the where the problem really is.