SlimeDog / PluginVersions

List installed plugins and versions alphabetically
MIT License
0 stars 1 forks source link

Folia compatibility #12

Closed SlimeDog closed 11 months ago

SlimeDog commented 1 year ago

🚩 We should do nothing until Folia reached a stage where the core functionality isn't bug fix du jour, and core plugins -- ProtocolLib, Vault, PlaceholderAPI, LuckPerms, etc. -- have been updated to actual releases. I'm not going to build all the prerequisites from branched dev sources.

If Folia becomes a significant number of servers that we need to support:

See PR https://github.com/SlimeDog/PluginVersions/pull/20

SlimeDog commented 1 year ago

This plugin was tested with a manually-edited plugin.jar on a manually-built Folia instance

> version
[06:40:49 INFO]: Checking version, please wait...
[06:40:50 INFO]: This server is running Folia version git-Folia-"5b74945" (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 5b74945)
You are running the latest version

It runs without error and performs commands correctly. However, please ensure that

PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:21:import java.util.concurrent.ScheduledExecutorService;
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:89:                        submitDataTask -> Bukkit.getScheduler().runTask(plugin, submitDataTask),
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:143:        private static final ScheduledExecutorService scheduler =
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:144:                Executors.newScheduledThreadPool(1, task -> new Thread(task, "bStats-Metrics"));
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:239:                            scheduler.shutdown();
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:257:            scheduler.schedule(submitTask, initialDelay, TimeUnit.MILLISECONDS);
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:258:            scheduler.scheduleAtFixedRate(
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/SpigotMetrics.java:278:            scheduler.execute(
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/BungeeMetrics.java:21:import java.util.concurrent.ScheduledExecutorService;
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/BungeeMetrics.java:153:        private static final ScheduledExecutorService scheduler =
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/BungeeMetrics.java:154:                Executors.newScheduledThreadPool(1, task -> new Thread(task, "bStats-Metrics"));
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/BungeeMetrics.java:249:                            scheduler.shutdown();
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/BungeeMetrics.java:267:            scheduler.schedule(submitTask, initialDelay, TimeUnit.MILLISECONDS);
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/BungeeMetrics.java:268:            scheduler.scheduleAtFixedRate(
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/BungeeMetrics.java:288:            scheduler.execute(
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:31:import java.util.concurrent.ScheduledExecutorService;
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:108:                        task -> server.getScheduler().buildTask(plugin, task).schedule(),
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:164:        private static final ScheduledExecutorService scheduler =
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:165:                Executors.newScheduledThreadPool(1, task -> new Thread(task, "bStats-Metrics"));
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:260:                            scheduler.shutdown();
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:278:            scheduler.schedule(submitTask, initialDelay, TimeUnit.MILLISECONDS);
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:279:            scheduler.scheduleAtFixedRate(
PluginVersions-master/src/main/java/com/straight8/rambeau//metrics/VelocityMetrics.java:299:            scheduler.execute(
PluginVersions-master/src/main/java/com/straight8/rambeau//bungee/UpdateChecker.java:30:        plugin.getProxy().getScheduler().schedule(this.plugin, () -> {
PluginVersions-master/src/main/java/com/straight8/rambeau//bungee/UpdateChecker.java:40:                plugin.getProxy().getScheduler().runAsync(this.plugin, () -> this.versionResponse.accept(latestVersion ? VersionResponse.LATEST : VersionResponse.FOUND_NEW, latestVersion ? this.currentVersion : fetchedVersion));
PluginVersions-master/src/main/java/com/straight8/rambeau//bungee/UpdateChecker.java:43:                plugin.getProxy().getScheduler().runAsync(this.plugin, () -> this.versionResponse.accept(VersionResponse.UNAVAILABLE, null));
PluginVersions-master/src/main/java/com/straight8/rambeau//velocity/UpdateChecker.java:31:        plugin.getServer().getScheduler().buildTask(this.plugin, () -> {
PluginVersions-master/src/main/java/com/straight8/rambeau//velocity/UpdateChecker.java:41:                plugin.getServer().getScheduler().buildTask(this.plugin, () -> this.versionResponse.accept(latestVersion ? VersionResponse.LATEST : VersionResponse.FOUND_NEW, latestVersion ? this.currentVersion : fetchedVersion)).schedule();
PluginVersions-master/src/main/java/com/straight8/rambeau//velocity/UpdateChecker.java:44:                plugin.getServer().getScheduler().buildTask(this.plugin, () -> this.versionResponse.accept(VersionResponse.UNAVAILABLE, null)).schedule();
PluginVersions-master/src/main/java/com/straight8/rambeau//velocity/UpdateChecker.java:46:        }).schedule();
PluginVersions-master/src/main/java/com/straight8/rambeau//bukkit/UpdateChecker.java:30:        plugin.getServer().getScheduler().runTaskAsynchronously(this.plugin, () -> {
PluginVersions-master/src/main/java/com/straight8/rambeau//bukkit/UpdateChecker.java:40:                plugin.getServer().getScheduler().runTask(this.plugin, () -> this.versionResponse.accept(latestVersion ? VersionResponse.LATEST : VersionResponse.FOUND_NEW, latestVersion ? this.currentVersion : fetchedVersion));
PluginVersions-master/src/main/java/com/straight8/rambeau//bukkit/UpdateChecker.java:43:                plugin.getServer().getScheduler().runTask(this.plugin, () -> this.versionResponse.accept(VersionResponse.UNAVAILABLE, null));

are not problematic, and there are no other scheduler-related issues.

SlimeDog commented 11 months ago

Re-open when Folia is ready for primetime.