SlimeDog / pHD

Manage holograms with intelligence
https://github.com/SlimeDog/pHD/wiki/
GNU General Public License v3.0
4 stars 0 forks source link

FancyHolograms support #45

Closed SlimeDog closed 3 months ago

SlimeDog commented 10 months ago

Is your feature request related to a problem? Please describe. Updates for DecentHolograms and HolographicDisplays are increasingly delayed. In order to hedge our bets, we should expand our offerings.

Describe the solution you'd like Add support for FancyHolograms. The API looks to be sufficient.

Describe alternatives you've considered None.

Additional context Add any other context or screenshots about the feature request here.

SlimeDog commented 10 months ago

Since it is possible -- even reasonable -- to run FancyHolograms in parallel with DecentHolograms or HolographicDisplays, I suppose we need to add a selector to the configuration, first-up after the header comments. Something like:

# ========== HOLOGRAM PROVIDER =====================================================================
# One of
#  DecentHolograms
#  FancyHolograms
#  HolographicDisplays
# If the configured hologram provider fails to load or enable,
# pHD will disable and post an ERROR message to the console/log.
hologram-provider: DecentHolograms

Such a specification should be required if more than one supported hologram provider is enabled.

Alternatively, we could support more than one hologram provider, if enabled. But we cannot guarantee that the hologram names would be unique. That could be resolved with a name header decentholograms:lobby-blackdog for example. And pHD could require resolution at the command invocation. But I'm not convinced that introducing that complexity is a good thing, given that most users will employ only one hologram provider.

Given current usage, DecentHolograms (60+%) should be the default, if the specification is missing (legacy configuration file, for example) and in the canonical configuration file. If usage statistics suggest otherwise in future, it can be changed in a subsequent release.

SlimeDog commented 10 months ago

This message

[07:44:52] [Server thread/ERROR]: [pHD] Disabling plugins. Problems: [NO_PLATFORM]

occurs at present, when there is no hologram provider. It should be something like

[07:44:52] [Server thread/ERROR]: [pHD] Disabling plugin. No hologram provider was found.

and perhaps should be configurable in messages.yml.

SlimeDog commented 3 months ago

Added in v 1.9.0