SlimeKnights / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
1.22k stars 773 forks source link

Crash on updating faucet connected to filling tank/gauge #3297

Closed Salsonn closed 4 years ago

Salsonn commented 6 years ago

This is...obnoxious.

I have a small smeltery to melt items, that immediately drains into a gauge, and then from the gauge into a Tinker Tank. In order to keep the liquid pouring I run a redstone clock of some sort that connects directly to the gauge and/or faucets to keep them updating. However if that clock updates the second faucet while the first one is pouring, the game crashes.

My current workaround is using clock-rigged Glowstone Lamps adjacent to the Faucets, while keeping the faucets constantly powered. This doesn't cause a crash, but it's a lot more complicated to set up.

crash-2017-12-23_04.22.07-server.txt

bonii-xx commented 6 years ago

Can you reproduce this reliably? You're running an old version of TiC, I think there was a fix in that region in that update. See if you can reproduce on 2.8.1.49

Salsonn commented 6 years ago

Sheesh, has it been a month already? Sorry for taking so long.

As of the latest TiC build, this doesn't seem to occur. Thanks for keeping this mod maintained!

Now I just need to figure out why my modpack can't load a world on the newer Forge versions so I can update TiC. [Edit: Updating mods is important, the pack loads now]

bonii-xx commented 6 years ago

It probably was one of the fixes in that update then. Great to hear that it works.

Salsonn commented 6 years ago

Wait... nevermind. It still happens. Looks like it doesn't like rapid-fire redstone pulses, cause I tried it using an observer clock and it started crashing again until I threw a repeater into the circuit. I don't have the crash report on me now, but I can provide soon.

bonii-xx commented 6 years ago

Yup, definitively needs a crash report.

Salsonn commented 6 years ago

Here we go.

crash-2018-01-20_00.04.38-server.txt

Also, is this a good way to upload crash reports, or is there a method you might prefer more?

bonii-xx commented 6 years ago

Uploading like that is fine. For small crashlogs like this one a pastebin is fine too, since it allows direct viewing online. Some people just use gists.

Anyway, sad to see that crash still exists, I was hoping exactly this crash was fixed in this release :(

bonii-xx commented 6 years ago

This crash doesn't make any sense ta all. Can you provide a screenshot of the setup? I can't reproduce it. The code happens inside forges FluidTank, but I don't see a single way this can possibly crash. Either some coremod messes with it (for what reason I can't imagine though) or I'm missing something.

Salsonn commented 6 years ago

Okay, this is embarrassing...I can't replicate it with the same setup...this is the setup I've been using to replicate it.

bonii-xx commented 6 years ago

Are you playing Singleplayer or on a Server? Does it crash the client or the server?

Salsonn commented 6 years ago

Singleplayer.the crash appears to be server-side, because it crashes before I log on.

KnightMiner commented 6 years ago

Same as #3390, this crash should be impossible. Seems to be some sort of race condition where Minecraft starts to empty the tank before it finished filling it. Not sure there is anything we can do as there is no place in the code to catch this crash, the stack is never null on the line its crashing. Try updating everything to the latest versions, and we will see if it still happens

Salsonn commented 6 years ago

Will do!

KnightMiner commented 5 years ago

Most likely fixed alongside #3390, as the slight delay will prevent a block update from immediately causing the faucet to pour.

KnightMiner commented 4 years ago

Should be in the 2.12.0.156 build, so closing this.