SlimeKnights / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
1.23k stars 776 forks source link

java.lang.IllegalStateException: vanilla model 'net.minecraft.client.renderer.block.model.ModelBlock@3d85a101' can't have non-vanilla parent #3576

Closed wormzjl closed 5 years ago

wormzjl commented 6 years ago

Sometimes happens on player login, can be resolved by removing all TiC blocks in the area https://gist.github.com/wormzjl/ca7906c8324b2b6fd882e47a1c36cf7b

bonii-xx commented 6 years ago

You can also disable the table rendering in the config. You have an item with a broken model in the table. Either that or projectred/codechickenlib screw with the models. Do you know which item it was?

wormzjl commented 6 years ago

Unfortunately no, and strangely it only crashes players that are logged in close to the object, not crashing other approaching players. I'll keep an eye on it next time it happens

bonii-xx commented 6 years ago

Please do. I suspect it might have to do with clientside mods though (optifine, etc)

wormzjl commented 6 years ago

Ok it happened again, but there is nothing on the table https://gist.github.com/wormzjl/f98a0f94121548c32c6524fc3af57d81

Also I don't have optfine, but the server has spongeforge

KnightMiner commented 6 years ago

Does it happen on a normal forge server?

bonii-xx commented 6 years ago

Does it happen without project red, who seem to modify the renedring?

wormzjl commented 6 years ago

Yes I had such report once when I removed sponge. For project red, I fear that I'm unable to do the test since it's a live server.

Peach774 commented 6 years ago

Got the same issue when moving from the nether to the overworld. No clue whats causing this since I do not have ProjectRed

bakkoting commented 6 years ago

I'm seeing the same thing. Here's a crash log.

This is a local copy of Modern Skyblock 3, running through MultiMC on Mac OS. It does not include Project Red, so that's not the problem. It seems to happen very consistently when logging in to my instance.

Since this is a local copy I'm happy to mess around with settings if there's things you'd like me to try. Or just send you a copy of my instance data, if that helps.

Setting B:renderInventoryInWorld=false and/or B:renderInventoryNullLayer=false does not fix it. Also, I'm very early game; I think the only things I've had in the table at any point were cobble, wood, and tool parts. Likely had cobble in there last, though since I can't log in it's hard to check.

KnightMiner commented 6 years ago

The biggest thing is reproducing with fewer mods so we can figure out exactly what mod causes it. I know it does not happen with normal Tinkers, so it has to be some mod modify the way all models load, but improperly.

bakkoting commented 6 years ago

@KnightMiner Removing moarTinkers seems to make it go away. (Updating that mod from 0.5.4 to 0.6.0 did not.)

Peach774 commented 6 years ago

Maybe it’s caused by addons in general? I don’t have moartinkers, but I have constructs armory. Maybe it has to do with the way the implement their casting molds or something with the casting mold code?

KnightMiner commented 6 years ago

Doubt it, I have seen this crash in other mods that use the Forge retexture method.

Mugiwaxar commented 6 years ago

Same issues for me here Happen since I've added the mod Wireless Redstone CBE The game crash when I'm near the table

KnightMiner commented 6 years ago

Does it happen without FoamFix? I'm pretty sure I've narrowed this down to that mod

pPkMnh4to8994h commented 6 years ago

same issue. https://gist.github.com/pPkMnh4to8994h/3133bcf0c66a5fc58b2dfd754d166055

KnightMiner commented 6 years ago

Great, can you try what I said above and test without FoamFix?

pPkMnh4to8994h commented 6 years ago

ye, without foamfix it seems to be working, but fps drops harshly, i barely can login in the world :(

KnightMiner commented 6 years ago

Thanks for the confirmation, this tells me I know the cause. Unfortunately it's not an easy fix on our side. It's an easy fix on Forges side but I still need to work on justifying it.

KnightMiner commented 6 years ago

Will be fixed by MinecraftForge/MinecraftForge#5195

KnightMiner commented 6 years ago

Alright, test this again with Forge build 2772 or later and FoamFix if you'd like

pPkMnh4to8994h commented 6 years ago

can't really tell if it's fixed since the bug is kinda "floating". if i will play a few days without this crash, maybe we can consider it as "fixed"...

KnightMiner commented 5 years ago

Closing this as fixed, as I know the specific cause I traced was related to that PR I linked