SlimeKnights / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
1.23k stars 776 forks source link

Pam's Harvestcraft intergration #4049

Closed chyper111 closed 4 years ago

chyper111 commented 4 years ago

Issue description: please make pam's tofu meats work to make moms spaghetti. I'm a vegan in real life and Minecraft and it would be awsome cuz that's how I like spaghetti.

If crashed, link to crash report (use a site such as pastebin):

Versions:

Can it be reproduced with just Tinkers Construct? If not, list the other mods required to reproduce the issue.

bonii-xx commented 4 years ago

Spaghetti is hardcoded to vanilla meats, and does not support any modded meats/meat supplements. TiC does not support any specific mods.

chyper111 commented 4 years ago

welp, then I guess no mom's spaghetti for me cuz me no kill animals.

On Fri, Feb 28, 2020 at 2:03 PM boni notifications@github.com wrote:

Spaghetti is hardcoded to vanilla meats, and does not support any modded meats/meat supplements.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SlimeKnights/TinkersConstruct/issues/4049?email_source=notifications&email_token=AMNTPOH6QJ4ZJ3FFZHARN3TRFFUYDA5CNFSM4K5HHSN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENJ7GEY#issuecomment-592704275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNTPOGQOWHS4IP7BJ3DNWTRFFUYDANCNFSM4K5HHSNQ .

KnightMiner commented 4 years ago

Support should already exist automatically, we use listAllmeatcooked for the list of meats that can be used to add meat to mom's spaghetti, which last I checked Pam's also used. However, the challenge is specifically you must have at least 3 different meats from that group, and I think tofu only counts towards one.

So basically, we support Pam's, but do not support tofu specifically.

chyper111 commented 4 years ago

how do i change it or do that cuz it would be awesome.

On Fri, Feb 28, 2020 at 4:59 PM KnightMiner notifications@github.com wrote:

Support should already exist automatically, we use listAllmeatcooked for the list of meats that can be used to add meat to mom's spaghetti, which last I checked Pam's also used. However, the challenge is specifically you must have at least 3 different meats from that group, and I think tofu only counts towards one.

So basically, we support Pam's, but do not support tofu specifically.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SlimeKnights/TinkersConstruct/issues/4049?email_source=notifications&email_token=AMNTPOFDOXABQRCGOAAR2WDRFGJNLA5CNFSM4K5HHSN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENKOXPQ#issuecomment-592767934, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNTPOHHSD62ENWSMDKJGATRFGJNLANCNFSM4K5HHSNQ .

KnightMiner commented 4 years ago

Add more meat alternatives to listAllmeatcooked. You can use a mod such as CraftTweaker to do this. Need at least 3 different meats to make the recipe.

bonii-xx commented 4 years ago

Whelp, you're right @KnightMiner, looked at the wrong line in the code. I was wondering if I misremembered that we use oredict...

chyper111 commented 4 years ago

um what config is it in? i cant find that line anywhere?

On Sat, Feb 29, 2020 at 11:39 AM boni notifications@github.com wrote:

Whelp, you're right @KnightMiner https://github.com/KnightMiner, looked at the wrong line in the code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SlimeKnights/TinkersConstruct/issues/4049?email_source=notifications&email_token=AMNTPOARE67DSTDTPGF5363RFFD4DA5CNFSM4K5HHSN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMAXRQ#issuecomment-592972742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMNTPODPILQX4HMK3T4KXJTRFFD4DANCNFSM4K5HHSNQ .

chyper111 commented 4 years ago

oh, nevermind I didn't see the craft tweaker thanks for the help.