SlimeKnights / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
1.24k stars 785 forks source link

Blindness not applying blurr to fluids inside smeltery or tanks. #4909

Open RaiXgame opened 2 years ago

RaiXgame commented 2 years ago

Minecraft Version

1.18.2

Forge Version

forge-1.18.2-40.1.51

Mantle Version

Mantle-1.18.2-1.9.27

Tinkers' Construct Version

TConstruct-1.18.2-3.5.1.31

Describe your issue

This issue is one I found playing vanilla mc, so it doesn't require of any other mods. (And I've actually tested it) What it causes is that any fluid that is inside a tank/smeltery/foundry to rend fullbright regardless of distance if seeable (no opaque blocks in between), that means that with blindness you can still see the fluids through the smeltrery windows and the fluid that is in the tanks. However, this does not happen on lamps.

The steps to reproduce this issue are: 1- Get a farmer villager and trade with them for suspicious stew of blindess, or craft it yourself. 2- Get a smeltery with windows or just fill a tank. 3- Eat tha wonderfull soup. 4- Contemplate the illumnation that the fluids give you.

Photos Lights off: image image image Photos Lights on: image image

P.D. I have searched for another issue like this, and I couldn't find it, so if there is another one like this, could you mention it?

Crash Report

There is no crash

Other mods

No other mods than Tinker's Construct and Mantle.

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues, Checked the FAQ

KnightMiner commented 1 year ago

Was sent this, how Mekanism solved the issue: https://github.com/mekanism/Mekanism/commit/7db26261f0a97cdf86ae2ee4557bff2344ed3a1c