SlimeKnights / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
1.24k stars 779 forks source link

Log spam related to armor items #5065

Closed Birbolion closed 1 year ago

Birbolion commented 1 year ago

Minecraft Version

1.18.2

Forge Version

40.0.2

Mantle Version

1.9.43

Tinkers' Construct Version

9.1.0.11

Describe your issue

This has to stem from the current plate armor embellishment issue, but seems to be interacting strangely with other mods when stack tracing, despite most of these mods not interacting with Tinkers at all to begin with. This is not a report on an isolated issue, I am simply just trying to help out in current endeavors. I have isolated one of these traces for reference.

[19Jan2023 21:09:54.988] [Worker-Main-3/WARN] [tconstruct/]: Tool stack constructed using non-modifiable tool, this may cause issues as it has no NBT. Stacktrace can be disabled in config. java.lang.Exception: Stack trace at slimeknights.tconstruct.library.tools.nbt.ToolStack.from(ToolStack.java:145) ~[TConstruct-1.18.2-3.6.1.88.jar%23171!/:1.18.2-3.6.1.88] at slimeknights.tconstruct.library.tools.nbt.ToolStack.from(ToolStack.java:163) ~[TConstruct-1.18.2-3.6.1.88.jar%23171!/:1.18.2-3.6.1.88] at slimeknights.tconstruct.library.tools.item.ModifiableArmorItem.setDamage(ModifiableArmorItem.java:209) ~[TConstruct-1.18.2-3.6.1.88.jar%23171!/:1.18.2-3.6.1.88] at net.minecraft.world.item.ItemStack.m41721(ItemStack.java:300) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.world.item.ItemStack.(ItemStack.java:147) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.world.item.ItemStack.(ItemStack.java:138) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.world.item.ItemStack.(ItemStack.java:126) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.advancements.DisplayInfo.m14986(DisplayInfo.java:113) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.advancements.DisplayInfo.m14981(DisplayInfo.java:96) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.advancements.Advancement$Builder.fromJson(Advancement.java:332) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.ServerAdvancementManager.m136037(ServerAdvancementManager.java:48) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.HashMap.forEach(Unknown Source) ~[?:?] at net.minecraft.server.ServerAdvancementManager.m5787(ServerAdvancementManager.java:45) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.ServerAdvancementManager.m5787(ServerAdvancementManager.java:24) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimplePreparableReloadListener.m10789(SimplePreparableReloadListener.java:13) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m10834(SimpleReloadInstance.java:68) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompletion.claim(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m10834(SimpleReloadInstance.java:68) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompletion.claim(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m10834(SimpleReloadInstance.java:68) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompletion.claim(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m10834(SimpleReloadInstance.java:68) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompletion.claim(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m10834(SimpleReloadInstance.java:68) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompletion.claim(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m10834(SimpleReloadInstance.java:68) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompletion.claim(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$Completion.run(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m143940(SimpleReloadInstance.java:69) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance.m10834(SimpleReloadInstance.java:68) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompletion.claim(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) ~[?:?] at java.util.concurrent.CompletableFuture.complete(Unknown Source) ~[?:?] at net.minecraft.server.packs.resources.SimpleReloadInstance$1.m10855(SimpleReloadInstance.java:51) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at net.minecraft.server.packs.resources.SimpleReloadInstance$1.m6769(SimpleReloadInstance.java:48) ~[server-1.18.2-20220404.173914-srg.jar%23206!/:?] at java.util.concurrent.CompletableFuture$UniCompose.tryFire(Unknown Source) [?:?] at java.util.concurrent.CompletableFuture.postComplete(Unknown Source) [?:?] at java.util.concurrent.CompletableFuture$AsyncSupply.run(Unknown Source) [?:?] at java.util.concurrent.CompletableFuture$AsyncSupply.exec(Unknown Source) [?:?] at java.util.concurrent.ForkJoinTask.doExec(Unknown Source) [?:?] at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown Source) [?:?] at java.util.concurrent.ForkJoinPool.scan(Unknown Source) [?:?] at java.util.concurrent.ForkJoinPool.runWorker(Unknown Source) [?:?] at java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source) [?:?]

Other than that, the same visual bug with the plate armor not rendering textures appears. Hopefully this will help out in solving the issue.

Crash Report

No response

Other mods

Waystones (by BlayTheNinth) Architectury API (Fabric/Forge) (by shedaniel) Shulker Box Slot (Forge) (by TheIllusiveC4) Experience Obelisk (by arcatex177) Polymorph (Forge) (by TheIllusiveC4) Simple Storage Network (by Lothrazar) HT's TreePlant (by hammertater) YUNG's Extras (Forge) (by YUNGNICKYOUNG) Farmer's Respite (by lumpazl) Enchantment Descriptions (by DarkhaxDev) JEI Integration (by SnowShock35) Create Stuff & Additions (by Furti_Two) Tinkers Construct (by mDiyo) Snad (by TheRoBrit) Large Meals (An Add-on for Farmer's Delight) (by LostWiz08) Chisels & Bits - For Forge (by AlgorithmX2) Dungeon Crawl (by xiroc_) Easy Villagers (by henkelmax) Emojiful (by Buuz135) Infernal Expansion (by InfernalStudios) Art of Forging: A Tetra Addon (by Eldritch_King24) Easy Magic (by Fuzs_) Magnesium/Rubidium Extras (by TeamDeusVult) Dual Riders (by Flytre7) Valhelsia Structures (by ValhelsiaTeam) Placebo (by Shadows_of_Fire) Guns Without Roses (by Lykrast) Tool Belt (by gigaherz) mutil (by mickelus) CoFH Core (by TeamCoFH) Death Compass (by vadis365) Presence Footsteps [Forge] (by Paint_Ninja) Cosmetic Armor Reworked (by LainMI) Comforts (Fabric/Forge/Quilt) (by TheIllusiveC4) ♪ Alex's Mobs EXTRA Music ♪ (by theexiiedfeiiow_) Collective (by Serilum) Flywheel (by jozufozu) Immersive Aircraft [Fabric/Forge] (by Conczin) Clumps (by Jaredlll08) Immersive Armors [Fabric/Forge] (by Conczin) SuperMartijn642's Core Lib (by SuperMartijn642) Locksmith (by moonflowerteam) More Dragon Eggs (by Darkere) Chipped (by terrariumearth) AutoRegLib (by Vazkii) FindMe (by Buuz135) Cooking for Blockheads (by BlayTheNinth) Croptopia (by thethonk) GraveStone Mod (by henkelmax) Just Enough Resources (JER) (by way2muchnoise) Iron Chests (by ProgWML6) Xtra Arrows (by Jackbusters1) Easy Piglins (by henkelmax) Mantle (by mDiyo) Thermal Expansion (by TeamCoFH) TheObsidianBoat (by UnRealDinnerbone) Puzzles Lib (by Fuzs_) Cucumber Library (by BlakeBr0) Thermal Cultivation (by TeamCoFH) Alex's Mobs (by sbom_xela) MrCrayfish's Furniture Mod (by MrCrayfish) FastFurnace (by Shadows_of_Fire) Too Fast (by Noobanidus) ForgeEndertech (by EnderLanky) Tetra (by mickelus) Mouse Tweaks (by YaLTeR) Tetra Pak (by Noobulus_Dos) Citadel (by sbom_xela) Just Enough Items (JEI) (by mezz) Ars Nouveau (by baileyholl2) MmmMmmMmmMmm (Target Dummy) (by MehVahdJukaar) Farsight [Forge] (by someaddon) Storage Drawers (by Texelsaur) Grappling Hook Mod (by yyonne) Customized Dungeon Loot (by XxRexRaptorxX) Spirit (by CodexAdrian) Builder's Delight (Forge) (by Tynoxs) Thermal Locomotion (by TeamCoFH) Materialis (by RCXcrafter) Mob Grinding Utils (by vadis365) Advanced Chimneys (by EnderLanky) Aquatic Torches (by realmayus) Better Compatibility Checker (by Gaz_) Enlightened End (Remade) (by MuffinsQw) YUNG's Better Desert Temples (Forge) (by YUNGNICKYOUNG) YUNG's Better Strongholds (Forge) (by YUNGNICKYOUNG) Entity Culling Fabric/Forge (by tr9zw) Simple Discord RPC [Forge/Fabric/Quilt] (by hypherionsa) YUNG's Bridges (Forge) (by YUNGNICKYOUNG) Caelus API (Forge) (by TheIllusiveC4) Additional Structures (by XxRexRaptorxX) Thermal Foundation (by TeamCoFH) Nether's Delight (by lumpazl) Lootr (Forge) (by Noobanidus) Grimoire of Tetra (by Vox4l) Enchantment Transfer [Forge] (by treekicker4) Portality (by Buuz135) Immersive Engineering (by BluSunrize) Create (by simibubi) Jade Addons (Forge) (by Snownee_) Create Deco (by talrey) Ars Elemental (by Alexth99) Packing Tape (by gigaherz) Trash Cans (by SuperMartijn642) Mekanism (by bradyaidanc) Jade 🔍 (by Snownee_) YUNG's API (Forge) (by YUNGNICKYOUNG) Cloth Config API (Fabric/Forge) (by shedaniel) EnderTanks (by ShetiPhian) Controlling (by Jaredlll08) Bookshelf (by DarkhaxDev) YUNG's Better Witch Huts (Forge) (by YUNGNICKYOUNG) JEI Enchantment Info (by Phylogeny) ShetiPhianCore (by ShetiPhian) YUNG's Better Mineshafts (Forge) (by YUNGNICKYOUNG) Corail Recycler (by Corail_31) Simple Shops (by wolforce) Iceberg [Forge] (by Grend_G) Industrial Foregoing (by Buuz135) Login Shield (by Glasspelican) The Undergarden (by Quek04) Curios API (Forge) (by TheIllusiveC4) Create Crafts & Additions (by MRHminer) Tinkers' Rapier (by sz0999312) Farmer's Delight (by vectorwing) YUNG's Better Dungeons (Forge) (by YUNGNICKYOUNG) Double Slabs (by CJMinecraft01) Titanium (by Buuz135) The Twilight Forest (by Benimatic) L_Ender 's Cataclysm (by mcl_ender) Flytre Lib (FlytreLib) (by Flytre7) Thermal Integration (by TeamCoFH) Traveler's Titles (Forge) (by YUNGNICKYOUNG) Blood Magic (by WayofTime) Pollen (by moonflowerteam) Carry On (by Tschipp) Better Third Person (by Socolio) Golden Hopper (by MrCrayfish) Thermal Innovation (by TeamCoFH) Charm of Undying (Fabric/Forge/Quilt) (by TheIllusiveC4) Xaero's World Map (by xaero96) Farming for Blockheads (by BlayTheNinth) More Ore Stones [FORGE] (by OrdanaryMods) Friends&Foes (Forge) (by faboslav) Mekanism Generators (by bradyaidanc) Ars Creo (by baileyholl2) Botania (by Vazkii) Domum Ornamentum (by OrionOnline) Simple Voice Chat (by henkelmax) Basic Nether Ores [Forge/Fabric] (by cScotPlay) NetherPortalFix (by BlayTheNinth) Sophisticated Core (by P3pp3rF1y) Pipez (by henkelmax) Mystical Agriculture (by BlakeBr0) Map Tooltip (by VendoAU) Redstone Pen (by wilechaote) Meet Your Fight (by Lykrast) Biomes O' Plenty (by Forstride) Crafting Tweaks (by BlayTheNinth) Elytra Slot (Forge) (by TheIllusiveC4) Balm (Forge Edition) (by BlayTheNinth) Sophisticated Backpacks (by P3pp3rF1y) Aquaculture 2 (by Shadowclaimer) AppleSkin (by squeek502) GeckoLib (by ThanosGecko) CodeChicken Lib 1.8.+ (by covers1624) Construction Wand (by ThetaDev) TerraBlender (Forge) (by TheAdubbz) ConnectedTexturesMod (by tterrag1098) FastWorkbench (by Shadows_of_Fire) YDM's Weapon Master (by YourDailyModderx) Fire Extinguisher - Stop Fire (by Kaworru) Equipment Compare [Forge] (by Grend_G) Patchouli (by Vazkii) Rubidium (by Asek3) Scuba Gear (by ModdingLegacy) Valhelsia Core (by ValhelsiaTeam)

Tried reproducing with just Tinkers?

No

Performance Enchancers

Magnesium, Other (specify under other mods)

Searched for known issues?

Checked pinned issues

Birbolion commented 1 year ago

Forgot to specify, but Rubidium is the "other" performance enhancer.

ShinyPorygon commented 1 year ago

If you're going to leave a long wall of log text either put it on pastebin or upload the whole log file as a text file. A long wall of text makes the issue hard to follow

KnightMiner commented 1 year ago

Fixed in 3.6.2.92