SlimeKnights / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
1.24k stars 785 forks source link

Ability to make modifier optional in enchantment to modifier recipes #5243

Open NyanMC opened 5 months ago

NyanMC commented 5 months ago

Minecraft Version

1.19.2

Forge Version

43.4.0

Mantle Version

1.10.36

Tinkers' Construct Version

3.8.3.39

Problem description

(quick note that this is for 1.19 and not 1.18 despite the labels that were assigned by default. there isn't a 1.19 enhancement template yet at the time of making this issue)

I have a work-in-progress addon to Tinkers Construct which adds a modifier which depends on an enchantment from another mod. The mod in question is not a hard dependency, therefore the modifier has to be conditional and can potentially not exist depending on the mod list. I wanted to add an enchantment-to-modifier recipe for this modifier, for turning the enchantment equivalent into the modifier, however when the modifier is not present, the game prints an error into the log file during runtime. This is not that big of an issue as the mod still works fine, but I would prefer to be able to prevent this error.

I brought this up in the Discord and was told to open an issue about this.

Suggested solution

The proposed solution is the ability to make the modifier in an enchantment-to-modifier recipe optional, as to prevent the aforementioned error when the modifier does not exist.

Alternatives considered

I considered the alternative of simply rewriting the modifier to not require the other mod in question. I may end up doing this, but it would be extra work and it isn't out of the question that I could run into this issue again if I end up making another modifier which depends on an enchantment from another mod.

Additional context

No response

Searched for existing enhancement?

Used the search bar, Checked the FAQ, Checked the in game books