search

SlimeKnights / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
1.24k stars 785 forks source link

the output of melting modifier weirdly disappears when the entity and the dropped item have the same recipe #5266

Open Jamesdsj opened 1 month ago

Jamesdsj commented 1 month ago

Minecraft Version

1.19.2

Forge Version

43.3.13

Mantle Version

1.10.36

Tinkers' Construct Version

3.8.4.50

Describe your issue

When attacking the mob using weapons with melting modifier, if the mob itself and its dropped item (e.g. slime) have the same melting result, the fluid amount may fluctuate. 2024-10-05_13 06 47 After I killed a large slime: 2024-10-05_13 07 01

Crash Report

No response

Other mods

none

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

None of the above

Searched for known issues?

Searched open issues

KnightMiner commented 1 month ago

Looks to me like you are in creative mode. Creative mode is known to make NBT inconsistent, and to be honest I doubt the weapons will work in creative to any reasonable degree. Try it in survival.

Jamesdsj commented 1 month ago

I tried, and it happened again.

KnightMiner commented 1 month ago

Hmm, quick glance at the source code suggests that the melting modifier is not properly melting dropped items, I think that it will just reset the tank to 0 before melting an item due to a typo.

To confirm, you could try melting a mob that has a drop with a different output than the mob itself, or mine a block with the melting modifier.

Bug is basically the same as the other melting bug we recently had, made a mistake when cleaning up the code in 1 or 2 modifiers.

Jamesdsj commented 1 month ago

I see. I remember that melting ores also has similar problem. I guess that is the reason. Thanks!