SlimeKnights / TinkersToolLeveling

Use tools. Gather xp. Get modifiers.
MIT License
34 stars 44 forks source link

[Forge 14.23.5.2847] Incompatibility bug with latest version of Mysticallib (6 October) #105

Closed Mythrrinthael closed 4 years ago

Mythrrinthael commented 4 years ago

Here's the crashlog.

The Mysticallib devs have this to say about it.

KnightMiner commented 4 years ago

Please post a cleaner crash log, one with just the required mods to reproduce (sounds like just tool leveling, Tinkers Construct, and Mystical Lib)

yuri0r commented 4 years ago

cleaner log

short overview: Mods: [✔️] Baubles-1.12-1.5.2 [✔️] Mantle-1.12-1.3.3.55 [✔️] mysticallib-1.12.2-1.3.8 [✔️] MysticWorld-1.12.2-1.4.5 [✔️] Patchouli-1.0-20 [✔️] Roots-1.12.2-3.0.14 [✔️] TConstruct-1.12.2-2.12.0.157 [✔️] TinkerToolLeveling-1.12.2-1.1.0

issiu postet on roots repo

pottentially usefull insight here

noobanidus commented 4 years ago

Honestly, after a good night's sleep and reconsidering it, I might be able to fix the issue entirely just by creating a local interface to check instanceof instead of relying on the class being loaded. If that fails, I can slap Loader.isModLoaded("mysticallib") into the first part of the check to prevent it from trying to (potentially) load a class that's failing.

I'll test this and release 3.0.15 if it does fix it.

noobanidus commented 4 years ago

I've pushed an update to CurseForge -- Roots 3.0.15 -- and, as far as I can tell, with my testing environment consisting of the following:

The issue no longer occurs. My solution was to create an empty interface and then extend from that, instead of relying on the assumption that MysticalLib would be loaded by the time attachCapability events were being called. Feel free to close this issue.

bonii-xx commented 4 years ago

Thanks @duely ❤️

noobanidus commented 4 years ago

Although I would recommend looking into ways to prevent ItemStack creation in static initialisation as it will probably cause problems with other mods.