search

SlimeKnights / TinkersToolLeveling

Use tools. Gather xp. Get modifiers.
MIT License
34 stars 43 forks source link

Battlesigns do not gain XP on block #90

Open votex09 opened 5 years ago

votex09 commented 5 years ago

I see on Sep 13, 2016 there was an issue open about blocking with signs gaining XP - was this idea implemented?

I'm playing SevTech Ages (1.12.2) and battlesigns do not gain any sort of XP on block, only when damaging something when swinging like a sword.

The installed version is: 1.0.5 - not totally updated. If this is implemented in a more up to date version, then disregard, else I'd have strong feelings to urge you to add this unless it was not implemented on purpose.

bonii-xx commented 5 years ago

As to my knowledge it works fine. Try reproducing with only TiC/Mantle and TTL, another mod might break things.

votex09 commented 5 years ago

When I have some time to test I'll gladly do it, my work schedule doesn't allow a whole lot of free time. Edit, so I played a little - I haven't made a pack with just tinkers things yet, but i notice it is getting XP... but only while reflecting projectiles as far as I can see.

bonii-xx commented 5 years ago

Blocking damage and reflecting projectiles are two separate events and unrelated code wise.

votex09 commented 5 years ago

Latest Version of Mantle, Tinkers and TTL: Freshly spawned Cactus Sign: image

After blocking one hit from a Zombie: image

After a few more hits and blocking a creeper explosion: image

So apparently the latest version does not have this implemented? image

votex09 commented 5 years ago

I tested again with forge 14.23.3.2678 (version reported in build.properties) and same result

SonicX8000 commented 5 years ago

This issue is still present. Blocking certain damage sources with a Battlesign will gain 0 XP however some damage sources gives XP if you block.

What will gain XP... Reflecting a projectile, such as an arrow. Standing in a fire. Being on fire. Touching a cactus. Burning your feet on a Magma Block. Swimming in Lava. Falling from a high place. Being in a wall. Drowning. Getting the ground too hard, a la Ender Pearl. Taking damage from Potion of Harming. Poison Damage. Wither Damage. Getting squashed by an Anvil. Blocking a Ghast Fireball. Reflecting a Blaze Fireball. Getting blown up by TNT. Falling out of the world. Getting /kill'd. See image below etc.

What won't gain XP... Melee-based damage, such as getting punched by a zombie. Blocking an Explosion from a mob, such as a Creeper. etc.

Given the the amount of sources that gives XP... not gaining any XP for blocking melee hits or explosions from mobs seems odd. Also... if you somehow managed to get /kill'd while blocking... this happens.

I think I broke it, at this point any XP gained grants a level... until Awesome+. Also you can overflow the XP value into the negatives if you had some XP and gained XP via /kill'd.

Minecraft: 1.12.2 Forge: 14.23.5.2824

Mods: 3 Mantle-1.12-1.3.3.49 TConstruct-1.12.2-2.12.0.135 TinkerToolLeveling-1.12.2-1.1.0