SlimeKnights / TinkersToolLeveling

Use tools. Gather xp. Get modifiers.
MIT License
34 stars 44 forks source link

[Suggestion] Gained Tool XP Cap of some sorts. #94

Open SonicX8000 opened 5 years ago

SonicX8000 commented 5 years ago

Running a mod alongside the Tinker's Tool Leveling where mob health increases as the time goes by, and one thing I have noticed is that Tool XP gained doesn't have a cap, meaning that if I kill a mob with... say 5020 health or something... the tool will gain 5020 XP once the mob dies. The only way around this is to mess with the configs to increase the XP limit but that would make it tricky to work with such as having a high XP limit from starting at low difficulties where mob health is near vanilla values.

I don't suppose an XP cap of some sorts could be added? Construct's Armory has a gained XP cap of 100 for the Armors meaning that if I took 3800 damage and lived... somehow, the armor will only gain 100 XP from that hit.

It could be a config option to enable/disable this cap or an adjustable value. Unsure of what the default value would be... would 100 be alright? This would mean that if I kill a Mob with more than 100 health, let's just say 1250, my tool will only get 100 XP due to the cap once the Mob dies.

SonicX8000 commented 5 years ago

If the above isn't an option then maybe a configurable multiplier of some sorts for the gained XP. For example...

I defeat a Mob that has 500 health, the multiplier is set at "0.5" which is half of the XP... the tool will only gain 250 XP.

XP Cap could still be a configurable option where I wish to cap the XP gains at 500 but having the XP gain multiplier set at "0.5". That way if I kill a mob with 5000 health my tool will only gain 2500 XP but if there's a XP Cap of 500... the Tool will only gain 500 XP meaning that 2000 of the XP is lost.

Just figure it would allow one to fine-tune the XP amounts for certain... purposes, like an RPG of some sorts.

By default, the XP Gain Multiplier would be at 1.0. I am not sure if there's even a cap on Tools.

SonicX8000 commented 5 years ago

Welp... apparently Tool XP appears to have no cap or it's bug'd with Battlesigns as you can gain 2147483147 XP with the Doom Potion effect via Extra Utilities 2's Death Generator or anything that can instant kill you while guarding.

Make a Battlesign, any Battlesign will do, craft the EU2 Death Generator and put some bones inside it... stand near it and you'll get the "Doom" potion effect. Before Doom's timer hits 0... guard with the Battlesign as when Doom's timer reaches 0 it will instant kill you... you'll notice that your Battlesign leveled up... check it's tooltip and you'll see that it has 2147483147 / 1000 XP, meaning that you can max out it's level easily if you gain more XP for it.

SonicX8000 commented 4 years ago

Any update for this by any chance? While it's only the Battlesign Tool, it's still quite an exploit to be gaining 2147483147 XP for 'guarding' an instant kill source with it.

You can also easily gain levels with damage source scaling from Scaling Health & hitting yourself with projectiles... such as shurikens & gain massive amounts of XP for blocking them. This requires the Battlesign to become Unbreakable with 5x Reinforced modifiers otherwise it'll just break within a few hits... then start throwing the shurikens straight up into the air & block them with the battlesign and watch as you gain levels here & there. It's quite an exploit & an XP cap of some sorts would fix this.

bonii-xx commented 4 years ago

I currently don't have time to deal with it, but it shouldn't be too hard to fix. Sounds like it always uses the damage that it's trying to deal, instead of the damage that's actually dealt. It requires other mods in a pretty endgame state to abuse, luckily.

As for getting lots of xp for dealing lots of damage, that's intended. if you deal 1k damage, you get 1k xp.