search

SlimeVR / SlimeVR-Feeder-App

WIP OpenVR Application that gets the position of everything to feed to SlimeVR-Server. In theory.
BSD 3-Clause "New" or "Revised" License
10 stars 8 forks source link

Don't send HMD to SlimeVR Server #15

Closed NWBx01 closed 1 year ago

NWBx01 commented 1 year ago

The SlimeVR OpenVR Driver and Feeder App both currently send the HMD to the SlimeVR Server, causing there to be a duplicate of the HMD. By not sending the HMD from the Feeder App, this resolves this issue.

I don't think there should be any problem with doing this, but this is mostly just in response to a cosmetic issue from there being two HMDs in the SlimeVR Server.

kitlith commented 1 year ago

So, it turns out that this fix is straight up incorrect, in multiple ways.

TrackedDeviceIndex is an steamvr concept that has nothing to do with roles -- if you're going to compare the TrackedDeviceIndex, you should compare against 0 -- aka k_unTrackedDeviceIndex_Hmd.

19 corresponds to SlimeVRPosition::HMD... which is also currently unused, in favor of SlimeVRPosition::Head, specifically so that slimevr server wouldn't have Issues with it: https://github.com/SlimeVR/SlimeVR-Feeder-App/commit/78410e5dae9be3ad5db373f9d81cccd1e4bc453e

I'm reverting this in favor of something else.