SlimeVR / SlimeVR-Rust

🦀 + SlimeVR = 💖
Apache License 2.0
70 stars 26 forks source link

overlay: Switch to standing universe, which is "close enough" #119

Closed kitlith closed 1 year ago

kitlith commented 1 year ago

Driver and Feeder now use a "static standing" universe, which should be the same as standing universe except it ignores playspace changing.

Ideally, we'd implement that here too, but this is better than leaving it the way it is. When playspace movement happens, I expect the skeleton to move relative to the player.

For future reference, this is how I handled it in feeder app: https://github.com/SlimeVR/SlimeVR-Feeder-App/blob/master/src/main.cpp#L660-L700

TheButlah commented 1 year ago

Looks like there's some formatting errors, can you run rustfmt?

kitlith commented 1 year ago

Looks like there's some formatting errors, can you run rustfmt?

Are you referring to the lint errors in the networking code I didn't touch?

TheButlah commented 1 year ago

The auto formatter errors yes. But like you said you didn't introduce those, so merging.