> Also a PR should clearly say what the change does, why isSlime matters? I have no idea what this change means for HID devices that aren't original slimes, for example
>
> I should have added, isSlime is how the GUI filters when you select the option to only show HMD and Slime trackers
>
> so there is already DIY slimes or any slime made by third-party, is this an original slime? I don't know what type/manufacturer is appropriate, or if this is a wrong implementation for the intended outcome
We want to have Manufacturer field to ideally display an actual manufacturer. But right now the UI uses it for filtering and converts into nebulous isSlime check that just checks manufacturer, instead of checking some other field. This needs to be remedied at some point:
[ ] Find a better property for UI to filter on when you check the show only trackers
[ ] Add manufacturer field to firmware and protocol, display it properly in UI and in other info, make it definable in build parameters so manufacturers could define it themselves if they want
Originally posted by @sctanf in https://github.com/SlimeVR/SlimeVR-Server/issues/1235#issuecomment-2469194549
We want to have Manufacturer field to ideally display an actual manufacturer. But right now the UI uses it for filtering and converts into nebulous isSlime check that just checks manufacturer, instead of checking some other field. This needs to be remedied at some point: