search

SlimeVoid / LittleBlocks-FML

LittleBlocks for FML
http://www.slimevoid.net/LittleBlocks
GNU Lesser General Public License v3.0
18 stars 13 forks source link

Play LB sounds in the main world #42

Closed Tarig0 closed 10 years ago

Tarig0 commented 11 years ago

using the little blocks alot has revealed that when a sound is supposed to be played such as walking on a block you won't here anything. is it possible to forward any sounds generated by the LB world to by played in the overworld?

Eurymachus commented 11 years ago

Just looked briefly into this, doesn't look possible without a forge hook. The step sound is retrieved from the block via the entity move.

A possible solution would be to create a getStepSound(World world, int x, int y, int z) inside block and have all references to blockInstance.stepSound use the getter. With the default getter returning this.stepSound allowing the function to be overriden by custom blocks and being location sensitive.

Will look into a pull request.

Tarig0 commented 11 years ago

Should probably add in the Entity to that function sig, or at least make the cords doubles.

Eurymachus commented 11 years ago

'This' should ofc be a parameter :)

Eurymachus commented 11 years ago

I'm having issues setting up forge fork atm. Getting an error running the setup.py

Binpatcher.jar not found

Tarig0 commented 11 years ago

No idea how to fix that, never actually did a fork from Forge. If you do get it working you wouldn't be able to do the same for block resistance would you? That would allow me to compress Slopes down a lot. I'll try to get it setup on my end but just in case you beat me.

Tarig0 commented 11 years ago

with our knowledge of the sound system is it possible to do this now?

Tarig0 commented 10 years ago

sounds seem to be handled minus changes in pitch/volume