Slimefun-Addon-Community / Galactifun

A Slimefun addon inspired by ClayTech
GNU General Public License v3.0
22 stars 24 forks source link

Damage taken every 10-20 seconds while in sealed room #68

Open Lennywasafish opened 3 years ago

Lennywasafish commented 3 years ago

Description (Required)

I created a small base in the earth's orbit in an enclosed space with iron blocks and glass. I have oxygen sealers and space heaters to stop damage which works for the most part, but every 10 seconds or so, I still seem to take damage. Every 4-5 hits of damage is freezing damage

Steps to reproduce the Issue (Required)

I have done everything including trying every type of block, making it a smaller space, removing windows, and removing automatic doors and it still consistently happens.

Expected behavior (Required)

I would take no damage

Server Log / Error Report

N/A

Environment (Required)

Seggan commented 3 years ago

try checking with /gf sealed <number>. find the lowest highest number that says "not sealed"

Seggan commented 3 years ago

correction: i meant highest. consider anything above 10000 as that your base is not fully sealed

Lennywasafish commented 3 years ago

I ran the command and it returned /gf sealed 1000000 and it returned Sealed 1.554 ms. I am still taking damage every 10 or so seconds though

Seggan commented 3 years ago

Find the highest number that says "Not sealed". This is very important for this issue

Lennywasafish commented 3 years ago

Find the highest number that says "Not sealed". This is very important for this issue

Regardless of the number I put in, it always gives the output of sealed. I have tried up to 1e9 before it gives me an internal error

Seggan commented 3 years ago

Try going down. i.e. 1000 or 5000

Seggan commented 3 years ago

Start from 100 then work your way up to 100000

Lennywasafish commented 3 years ago

Start from 100 then work your way up to 100000

1-1572 gives the output of not sealed but anything above that gives sealed

Seggan commented 3 years ago

Hmm

Lennywasafish commented 3 years ago

Hmm

updated reply with exact numbers

Seggan commented 3 years ago

What do your Space Heaters say? And whats the report of /gf effects?

Lennywasafish commented 3 years ago

What do your Space Heaters say?

operational

Seggan commented 3 years ago

Edited

Lennywasafish commented 3 years ago

I get no output

Lennywasafish commented 3 years ago

As stated in my original report, I take damage from lack of oxygen the first 5 times, then I take freezing damage

Seggan commented 3 years ago

Yes, ik, I was trying to diagnose further

Lennywasafish commented 3 years ago

If you'd like, I can add you on discord and dm you the ip to my server and you can test for yourself

Seggan commented 3 years ago

Strange that other have not reported it yet

Lennywasafish commented 3 years ago

Yeah it seems like a problem specific to me

Seggan commented 3 years ago

If you'd like, I can add you on discord and dm you the ip to my server and you can test for yourself

I can't unfortunately, my MC acc is being used rn

Lennywasafish commented 3 years ago

Ok no worries

Lennywasafish commented 3 years ago

I can send a screen recording if you'd like

Seggan commented 3 years ago

Sure

Lennywasafish commented 3 years ago

https://imgur.com/LurrPYy

Seggan commented 3 years ago

Super fans work only horizontally and diagonally (on the x/z axis)

Seggan commented 3 years ago

Try moving them

Lennywasafish commented 3 years ago

I've placed them everywhere, no difference, the problem also persists in a 5x5 room without superfans so that isn't the issue

Seggan commented 3 years ago

This is very strange

Seggan commented 3 years ago

Also take note of #69 perhaps that is the problem?

Lennywasafish commented 3 years ago

Yeah I made that issue too, that only applies to trapdoors that are on the bottom side of the block

Lennywasafish commented 3 years ago

And it happens while standing on iron blocks too

Seggan commented 3 years ago

I don't know how to resolve this, I do not know what is causing it. Sorry.

Lennywasafish commented 3 years ago

Ok, thanks for trying

orangeowie4 commented 3 years ago

this happens to me too sometimes

char3210 commented 3 years ago

Can you add me on discord? (Char#5513) Maybe I'll give this issue a tackle

Seggan commented 3 years ago

Join the Slimefun Addon Community Discord: https://discord.gg/SqD3gg5SAU

Modog500000 commented 3 years ago

Ok, thanks for trying

Wait did you have ion dispensers?

Ironnoob73 commented 2 years ago

I have the same problem.

Seggan commented 2 years ago

No errors?

vojtaBerry2 commented 2 years ago

Strange that other have not reported it yet

i have the same problem

Seggan commented 2 years ago

Please send me any errors and the output of /gf effects

JTechGaming commented 2 years ago

i have same problems

JTechGaming commented 2 years ago

https://youtu.be/GWwV8FELXTM

Derbosik commented 2 years ago

Same issue here

GallowsDove commented 2 years ago

The only reason I can think of why this is happening is that in ProtectingBlock

private void uniqueTick() {
    //noinspection deprecation
    Galactifun.protectionManager().clearProtectedBlocks();
    for (BlockPosition l : new HashSet<>(allBlocks)) {
        updateProtections(l);
    }
}

The protection blocks are cleared first and only then are they calculated and readded. There can be a brief window where the protection isn't added yet, but on another thread, it can be checked whether that protection exists, thus creating a race condition. A possible fix could be to calculate all the protections before clearing them and just replace the old ones with the new ones.

I'm not sure about this tho, so let me know what you think

Seggan commented 2 years ago

That's what I was thinking, but the ticker is synchronised