search

Slimefun-Addon-Community / Galactifun

A Slimefun addon inspired by ClayTech
GNU General Public License v3.0
22 stars 24 forks source link

improvements #7

Closed Mooy1 closed 3 years ago

GallowsDove commented 3 years ago

Wouldn't it be good to move the static declarations like MOON_LIKE into another class outside the API?

Mooy1 commented 3 years ago

renamed teleport cuz GalacticTeleport is more descriptive.

ProfElements commented 3 years ago

GalacticTeleport doesnt denote it is a command, though I do think having a the prefix does give it more descriptiveness

GallowsDove commented 3 years ago

I don't see a reason to request review when you haven't addressed the issues above.

Mooy1 commented 3 years ago

GalacticTeleport doesnt denote it is a command, though I do think having a the prefix does give it more descriptivenes

tru

Seggan commented 3 years ago

GalacticTeleport doesnt denote it is a command, though I do think having a the prefix does give it more descriptiveness

I agree. Maybe something like GFTPCommand?

Mooy1 commented 3 years ago

GalacticTeleport doesnt denote it is a command, though I do think having a the prefix does give it more descriptiveness

I agree. Maybe something like GFTPCommand?

Maybe GalactiportCommand

Seggan commented 3 years ago

Sure