search

Slimefun-Addon-Community / HeadLimiter

GNU General Public License v3.0
0 stars 6 forks source link

Added count command #7

Closed Sfiguz7 closed 3 years ago

Sfiguz7 commented 3 years ago

Had to change a couple things in the main class, the command works like a charm as seen in the pic (yay for on field tests), if you have anything to complain about for the aesthetics I'm all ears but also stop being picky (I'm looking at you Walshy) The output is a little tiny bit weird, especially CARGO_NODE for the connectors - this is what their actual ID is though so I thought I'd leave it as it may be useful to server admins. Again, open to suggestions. CountCommand

Sfiguz7 commented 3 years ago

stress Bit more of a stress test just to push it, 10ms

J3fftw1 commented 3 years ago

I could be completely wrong here but werent you supposed to not use blockstorage? I see a line of code with blockstorage so just asking also @WalshyDev review plox

Sfiguz7 commented 3 years ago

I could be completely wrong here but werent you supposed to not use blockstorage? I see a line of code with blockstorage so just asking also @WalshyDev review plox

Well I kinda need to check whether they are cargo or not; also unlike what Walshy said you do use BlockStorage to begin with sooo ahaha I don't think there's any feasible way around this

As for Walshy's changes, will modify in a bit. Not sure what to add for color but eh will come up with something not too rainbowy

WalshyDev commented 3 years ago

LGTM @J3fftw1 merge

J3fftw1 commented 3 years ago

If it looks good to walshy im fine with it