Slimefun-Addon-Community / LiteXpansion

GNU General Public License v3.0
11 stars 26 forks source link

[BUG] Mass fabricator count/percentage inaccuracy #11

Open mrcoffee1026 opened 3 years ago

mrcoffee1026 commented 3 years ago

Description (REQUIRED)

Percentage done with scrap: At no use: "Progress" https://prntscr.com/wgzjdy

At 198 scrap: https://prnt.sc/wgzmjs At 199 scrap: https://prnt.sc/wgzlvn At 200 scrap: https://prnt.sc/wgzsp4

At 198-200 items, the above screen shots are repeated identically. Seems to only be an issue that "1%" displays on placing in scrap #200. There is not really 1% in the machine, it is technically at a count of 0 and will require 200 scrap at that point. As it shows "100%" at 199 items, the % complete appears to just be doing a rounding error where it might only be 99.5% complete and is just calling it 100%, that doesn't quite explain the 1% complete when 0 items have been input though. It used to need an extra scrap to push the final uu-matter through, although breaking and replacing the machine has resulted in the behavior shown here.

Scrap 201: https://prnt.sc/wgzzwa Scrap 202: https://prntscr.com/wh0062

Steps to reproduce the Issue (REQUIRED)

Insert scrap and note status of % complete.

Expected behavior (REQUIRED)

Should not display 100% until 200/200 items are in machine. Should show 0% when 0/200 scrap is in machine.

Server Log

Nothing relevant.

Environment (REQUIRED)

[15:06:25 INFO]: This Server uses the following setup of Slimefun: [15:06:25 INFO]: Paper v1_16_R3 [15:06:25 INFO]: CS-CoreLib vDEV - 92 (git e9150d72) [15:06:25 INFO]: Slimefun vDEV - 771 (git f2dd3a01) [15:06:25 INFO]: Metrics build: #6 [15:06:25 INFO]: [15:06:25 INFO]: Installed Addons: (29) [15:06:25 INFO]: GlobalWarming vDEV - 6 (git 3aca6557) [15:06:25 INFO]: SlimyPowerSuits vDEV - 9 (git 6d6bb2e7) [15:06:25 INFO]: ExtraTools vDEV - 23 (git 9299a65c) [15:06:25 INFO]: FoxyMachines vDEV - 9 (git 27240b97) [15:06:25 INFO]: SlimefunOreChunks vDEV - 10 (git 91df3b8e) [15:06:25 INFO]: SensibleToolbox vDEV - 36 (git bcb849b5) [15:06:25 INFO]: ExtraGear vDEV - 12 (git 4570ea2c) [15:06:25 INFO]: MoreTools vDEV - 9 (git e8cfb32c) [15:06:25 INFO]: InfinityExpansion vDEV - 54 (git 8f049149) [15:06:25 INFO]: SFCalc vDEV - 14 (git 8d205b67) [15:06:25 INFO]: ElectricSpawners vDEV - 19 (git d1293bf2) [15:06:25 INFO]: ExtraHeads vDEV - 18 (git ec4e19f2) [15:06:25 INFO]: MobCapturer vDEV - 11 (git 4edf38dd) [15:06:25 INFO]: SlimyTreeTaps vDEV - 16 (git 46272e92) [15:06:25 INFO]: PrivateStorage vDEV - 15 (git a0fbc572) [15:06:25 INFO]: TranscEndence vDEV - 22 (git 7660c9f0) [15:06:25 INFO]: FluffyMachines vDEV - 58 (git 097bb2e9) [15:06:25 INFO]: CMI v8.7.12.5 [15:06:25 INFO]: ChestTerminal vDEV - 38 (git c024be5c) [15:06:25 INFO]: DyedBackpacks vDEV - 11 (git b8eda0c7) [15:06:25 INFO]: SoundMuffler vDEV - 19 (git 5caef292) [15:06:25 INFO]: SlimefunWarfare vDEV - 11 (git 001a2946) [15:06:25 INFO]: EcoPower vDEV - 2 (git b0c0c875) [15:06:25 INFO]: HotbarPets vDEV - 33 (git ed485955) [15:06:25 INFO]: SlimefunLuckyBlocks vDEV - 30 (git 26824119) [15:06:25 INFO]: ExoticGarden vDEV - 64 (git ef338f99) [15:06:25 INFO]: Liquid vDEV - 5 (git fabacb37) [15:06:25 INFO]: LiteXpansion vDEV - 114 (git 061c0798) [15:06:25 INFO]: SoulJars vDEV - 18 (git 098ad836)

This server is running Paper version git-Paper-366 (MC: 1.16.4) (Implementing API version 1.16.4-R0.1-SNAPSHOT)

J3fftw1 commented 2 years ago

Sorry for almost a year late reply but this is a SF issue. Im keeping this open so we dont forget about it but the Mass Fab makes use of a method called updateProgressbar and that is from Slimefun