Recycler and Mass fab fix

Slimefun-Addon-Community / LiteXpansion

GNU General Public License v3.0

11 stars 26 forks source link

Recycler and Mass fab fix #2

Closed NCBPFluffyBear closed 3 years ago

NCBPFluffyBear commented 3 years ago

Short Description

Input and output slots are no longer wiped when the server restarts, machines drop inventory when broken

Additions/Changes/Removals

Fixed preset so that the input and output slots are no longer wiped when the server restarts
Added block handler so that they drop input/outputs when broken

Related Issues

Issue that has been bugging ppl for a while, seen here and there on discord.

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have also tested the proposed changes in combination with base Slimefun and made sure nothing breaks/unexpected happens.
[x] I followed the existing code standards and didn't mess up the formatting.
[ ] I did my best to add documentation to any public classes or methods I added which may not be obvious to maintainers.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

J3fftw1 commented 3 years ago

video of it working?

J3fftw1 commented 3 years ago

i feel like this would be more suited for SF then LX take it down at the core so we dont need to implement it each time imma the check the pr anyways and merge it aswell since ugh people but this should be tackled on SF lvl not LX

bobhenl commented 3 years ago

It was sent to Discord @J3fftw1 https://streamable.com/4zawfz

bobhenl commented 3 years ago

And may it could be PRed to SF if it would solve issue better.

J3fftw1 commented 3 years ago

https://i.imgur.com/Ps2lUfZ.png

NCBPFluffyBear commented 3 years ago

It was sent to Discord @J3fftw1 https://streamable.com/4zawfz

This is only the comparison video between a sf machine and lx machine, ill make a video of it working later

And may it could be PRed to SF if it would solve issue better.

Also why this doesnt make sense bc its already in slimefun, lx just doesnt have it bc they custom build their presets instead of acontainer

J3fftw1 commented 3 years ago

When you are working on this anyways can you implement when you break the machine it drops it inventory slots

J3fftw1 commented 3 years ago

It was sent to Discord @J3fftw1 https://streamable.com/4zawfz

This is only the comparison video between a sf machine and lx machine, ill make a video of it working later

And may it could be PRed to SF if it would solve issue better.

Also why this doesnt make sense bc its already in slimefun, lx just doesnt have it bc they custom build their presets instead of acontainer

Yea make sense now though we used something from sf that used it if i were in the discord. We could have talked about it. Not being there is a struggle for these things

NCBPFluffyBear commented 3 years ago

https://streamable.com/9nu5io