Fixed Auto-Crafter issue

Slimefun-Addon-Community / LiteXpansion

GNU General Public License v3.0

10 stars 25 forks source link

Fixed Auto-Crafter issue #41

Closed Laci444 closed 3 years ago

Laci444 commented 3 years ago

Short Description

I fixed the issue with the Auto-Crafters.

Additions/Changes/Removals

UU-Matter recipes can be used in Auto-Crafters.

Related Issues

Resolves #35

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have also tested the proposed changes in combination with base Slimefun and made sure nothing breaks/unexpected happens.
[x] I followed the existing code standards and didn't mess up the formatting.
[x] I did my best to add documentation to any public classes or methods I added which may not be obvious to maintainers.
[x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

J3fftw1 commented 3 years ago

Hey, Thanks for the pr i got some other things i do want to change @WalshyDev and I have been talking about adding our own auto crafter for LiteXpansion that work with the UU matter stuff. This crafter purpose will solely be crafting uu matter into other items. But that might be out of the scope of the PR but thats up to you we could always change it later on. Thanks again for making the PR <3

Laci444 commented 3 years ago

Im not the biggest fan of making them all slimefun items since they are just vanilla items @WalshyDev what do you think

This is the only solution I found without changing the Auto-Crafters or adding new ones.

J3fftw1 commented 3 years ago

Im not the biggest fan of making them all slimefun items since they are just vanilla items @WalshyDev what do you think

This is the only solution I found without changing the Auto-Crafters or adding new ones.

I'm pretty sure if you do it this way the items aren't usable in vanilla crafting tables anymore since they aren't actually vanilla items anymore because you add a SF ID

WalshyDev commented 3 years ago

This PR has a few issues but the main one is you're now causing all these vanilla items to have an NBT tag which is redundant. This will cause stacking issues and issues with other plugins.

The best solution to this is our own crafter. The issue is due to these not being SF items (which we don't want them to be) but that's required for the enhanced crafter. Our own table will check if there's an enhanced recipe for our vanilla item.

So, due to this PR not doing an appropriate fix I will be closing it, if you wish to PR with a new auto-crafter then you're free to do so.