search

Slimefun-Addon-Community / LiteXpansion

GNU General Public License v3.0
11 stars 26 forks source link

[BUG] UU-Matter can not be placed into item frames. #80

Open Skizzles opened 1 year ago

Skizzles commented 1 year ago

Description (REQUIRED)

UU-Matter seems to block right click due to being use to dye sheep based off what Panda stated in dms.

Steps to reproduce the Issue (REQUIRED)

Place itemframe Right click with uu-matter

Expected behavior (REQUIRED)

Allow the uu-matter into item frames as it can be used for storage labeling

Server Log

N/A

Environment (REQUIRED)

Sefiraat commented 1 year ago

@J3fftw1 think we discussed this vaguely before, but I think a class PRd to slimefun or another lib that protects items like this from all destructive actions while retaining other functions like this as I know crysta and networks has a use for it and I’m sure other’s will also

J3fftw1 commented 1 year ago

Jup this been a long standing issue. Im just thinking of how we can solve this. Since there is for dye multiple ways to apply it Sheep Signs Some do want to allow sheep, for example slimefun. Forgot the item name.

Sefiraat commented 1 year ago

We just have a ProtectedSlimefunItem class (or whatever) with ItemHandlers for all these things that stops the action with a quick check for a Boolean that can be overridden by implementing classes as required.