Slimefun-Addon-Community / LiteXpansion

GNU General Public License v3.0
11 stars 26 forks source link

Add SlimeTech compatibility #87

Closed PhoenixCodingStuff closed 1 year ago

PhoenixCodingStuff commented 1 year ago

Short Description

Add SlimeTech compatibility Change register logic

Additions/Changes/Removals

Added SlimeTech rubber item Changed register logic

Related Issues

N/A

Checklist

J3fftw1 commented 1 year ago

Have you tested this? im 99% sure this will break recipes in litexpansions that require item id rubber.

PhoenixCodingStuff commented 1 year ago

I'll make the necessary code changes in sometime and test it. Also just a clarification does prioritising meaning putting SlimeTech first in the if statement? If yes then I'll switch it to SlimyTreeTaps first.

J3fftw1 commented 1 year ago

I'll make the necessary code changes in sometime and test it. Also just a clarification does prioritising meaning putting SlimeTech first in the if statement? If yes then I'll switch it to SlimyTreeTaps first.

yes :d

PhoenixCodingStuff commented 1 year ago

Screenshot_2023-08-30-11-12-27-556_net.kdt.pojavlaunch.jpg

Screenshot_2023-08-30-11-12-37-039_net.kdt.pojavlaunch.jpg

Screenshot_2023-08-30-11-15-48-452_net.kdt.pojavlaunch.jpg

Screenshot_2023-08-30-11-16-07-714_net.kdt.pojavlaunch.jpg

PhoenixCodingStuff commented 1 year ago

dun

PhoenixCodingStuff commented 1 year ago

Done, I thought if you do something more than once (this.rubberItem) it would be better to create a local variable instead. I fixed it.

PhoenixCodingStuff commented 1 year ago

Walshy just told me to rename to rubber

J3fftw1 commented 1 year ago

ugh @WalshyDev we have conflicting reviews there is no need to make the diff bigger then it is

PhoenixCodingStuff commented 1 year ago

Am I supposed to create local variables or nah? Also rubber or rubberItem

WalshyDev commented 1 year ago

The diff literally cannot get smaller..

WalshyDev commented 1 year ago

Changing to rubber would be MORE not less.