1.20.4 Functionality

[petulikan1]

Short Description

I've updated the plugin to work with 1.20.4 and ensured that custom glow enchantment remains working on the latest version.

Additions/Changes/Removals

Due to hard spigot Enchantment class changes, I've had to use NMS (net.minecraft.server) to make the glowing enchant work properly. As of that, I had to separate the Core part of the plugin and the NMS part in the projetct so the dependencies wouldn't mix alltogether and possibly even prevent compilation.

Related Issues

Resolves #90

Checklist

• [x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
• [x] I have also tested the proposed changes in combination with base Slimefun and made sure nothing breaks/unexpected happens.
• [x] I followed the existing code standards and didn't mess up the formatting.
• [x] I did my best to add documentation to any public classes or methods I added which may not be obvious to maintainers.
• [x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values

[petulikan1]

I'd like to also mention that merging this will result breaking the auto-artifact-building system as the Spigot's NMS aren't available online anywhere and can only be built locally.

I've also tried to remove all the NMS parts and change them into reflections, but because we're overriding methods from a class unobtainable during compilation that's sadly not possible without much complex reflection logic and dynamic class creation which would make it more unreadable and hard to read.

//EDIT

I tried making it with Javassist but without a chance... https://pastebin.com/WwPrMsjG