Slimefun-Addon-Community / Supreme

An addon for slimefun
GNU General Public License v3.0
6 stars 21 forks source link

Fix Generator Mob Concurrent Problems #40

Closed JustAHuman-xD closed 1 year ago

JustAHuman-xD commented 1 year ago

Completely change the approach on the Generator Mob Cache, should fix any errors due to concurrent modification, the only downside to this approach is that the recognizing that the mob is in range and that a mob is no longer in range is slightly delayed, but overall it shouldn't matter.

RelativoBR commented 1 year ago

evidence: image

JustAHuman-xD commented 1 year ago

Interesting, I'm going to push some debug messages, if you could provide a log with that version I should be able to find the issue

RelativoBR commented 1 year ago

@JustAHuman-xD image image

RelativoBR commented 1 year ago

I imagine what you say is perhaps related to the last change that is in the main branch. (https://github.com/Slimefun-Addon-Community/Supreme/pull/35)

JustAHuman-xD commented 1 year ago

Interesting, I'll be home soon hopefully I can fix and be done with it soon 👍

JustAHuman-xD commented 1 year ago

With optimizations: image

Without: image

RelativoBR commented 1 year ago

passed the tests