Slimefun-Addon-Community / Supreme

An addon for slimefun
GNU General Public License v3.0
6 stars 21 forks source link

Fix Misspellings & Improve Performance #42

Closed JustAHuman-xD closed 1 year ago

JustAHuman-xD commented 1 year ago

This PR basically replaces #37 Helps with #36 The tech generator performance issue is not as easy to solve as most of the problems areas are essential to the machine and are laggy from slimefun method calls.

JustAHuman-xD commented 1 year ago

All of this is untested atm, if anyone else wants to test it that would be appreciated, but I will be able to test it whenever I get home.

RelativoBR commented 1 year ago

I'm testing the change, if there was any problem in their operation, but part of the large-scale development, I can't validate

JustAHuman-xD commented 1 year ago

Did you test that using mob tech properly changed everything?

RelativoBR commented 1 year ago

I tested the 3 machines with different tier and types, they worked correctly.

SrMonsterYT commented 1 year ago

lag tripled in version #25 supreme

version supreme #23 -> https://prnt.sc/2snKITZHsMC4 version supreme #25 -> https://prnt.sc/mWR7vm7wOqb9

timings paper: https://timings.aikar.co/dev/?id=bd1a2c9d88b34f72b2eeb89069bb6c1c

timings spark: https://spark.lucko.me/d8tUnWFBSx

@JustAHuman-xD

JustAHuman-xD commented 1 year ago

Try with the new version, lag should be le gone

SrMonsterYT commented 1 year ago

Try with the new version, lag should be le gone

there is still a problem in supreme, see

timings paper: https://timings.aikar.co/dev/?id=610ae37862014835a87df55eb59fc430 spark timings: https://spark.lucko.me/w76fiWIMTG

image 1: https://prnt.sc/5SWy-Meyadto image 2: https://prnt.sc/iMG9mFUeBuRo

my slimefun always stays at 20% in plugins when i update supreme it stays between 60% - 67% i don't know what's going on but these updates in supreme increased the performance a lot

supreme version #26 I'm going back to version #23 where there is no tps drop and no increase in slimefun

@JustAHuman-xD