Misc Supreme Optimizations

Slimefun-Addon-Community / Supreme

An addon for slimefun

GNU General Public License v3.0

6 stars 20 forks source link

Misc Supreme Optimizations #44

Closed JustAHuman-xD closed 1 year ago

JustAHuman-xD commented 1 year ago

This PR:

Fixes some Misspellings
Optimizes TechMutation & TechRobotic by removing unnecessary .clone() calls from SlimefunItemStack
Optimizes TechGenerator by adding the tier & type of MobTech to its NBT data, to remove the laggy SlimefunItem#fromItem call. If the item does not have the relevant NBT it will fallback to the SlimefunItem#fromItem and if it is a MobTech it will add the relevant NBT data.

JustAHuman-xD commented 1 year ago

Just need to do the testing for this, tried to test but I honestly don't know how MobTech works in supreme 😅

RelativoBR commented 1 year ago

@JustAHuman-xD Tests carried out, both the old items and the new ones are working correctly, but they are no longer accumulating, which is common whenever there is an attribute change in the items, for this case there is already a contour action with the item convert machine that resets attributes to initial value.

JustAHuman-xD commented 1 year ago

Alright is there anything else you think is necessary before merging?

JustAHuman-xD commented 1 year ago

Also can you send the full timings report for those screenshots of sf timings, if you have it anyway?

RelativoBR commented 1 year ago

I don't have this complete report (I don't know how to generate it either), I imagine that everything is fine for the merge, the change is as expected and there are no impacts for players, except for the union of old and new items in the same stack (something inevitable).