Dupe (not dupe, but you can make an higher level of a item, using only 1) bug in all electric machines in supreme.

davidcanas commented 1 year ago

Description (Required)

I found out that all supreme machines can be used to dupe, so if you want to make a magic sword and you only have 1 thornium sword, with this bug, you can easily solve this problem, you just need to create a netherite sword, rename it "&lThornium Sword" (in this case) and then craft normally, and use this sword instead of a real thornium sword. There's also another bug, which is that when you craft an item, you can take one of them back from the machine, for example the most valuable one, and the craft continues...

Steps to reproduce the Issue (Required)

Craft an Electric Gear Fabricator (or other electric machine, the bug works with that too)
Craft a thornium sword
Craft a netherite sword
Rename the netherite sword "Thornium Sword"
Place the other materials in the machine
Place the two swords, the real one and the fake one
That's it, the machine will recognize that the craft is valid... and you'll have an improved sword without spending 2 of them

Expected behavior (Required)

Not recognizing the craft as valid. Not being able to remove items during the crafting process, and the craft continuing...

Server Log / Error Report

https://mclo.gs/IVzadAT

Environment (Required)

https://prnt.sc/21a91YH135Qj

Minecraft Version: 1.20.1
CS-CoreLib Version: in 1.20 slimefun doesnt needs that
Slimefun Version: DEV - 1100 (git d683a633)
Plugin Version: vDev - 29 (in the screenshot shows the versions)

https://github.com/Slimefun-Addon-Community/Supreme/assets/70149057/b7d55cc4-1377-47b4-b02c-d283423da4be

davidcanas commented 6 months ago

It has not been resolved yet .... It's possible to double everything with that. Spoiling the game experience.

Boomer-1 commented 5 months ago

rename is a command that's not available to players without being given perms from another addon outside of slimefun. that would be on that plugin to not allow it

davidcanas commented 5 months ago

@Boomer-1 Players don't have access to /rename, they're using Anvil.

They also don't have permission to use formatting codes (like &l) on the anvil, but the supreme recognizes it anyway

Boomer-1 commented 5 months ago

i've never seen an anvil renamed item get recognized by slimefun without the help of an external plugin. i can't replicate it

davidcanas commented 5 months ago

Have you seen the vídeo? Just craft a normal netherite sword and rename it to "Thornium sword" on the anvil, for example. After that, in the eletric machine, put a real thornium sword on top, and a fake one on the bottom, and he'll do a magic sword with only 1 thornium sword.

Later I'll try to replicate it again, on that server I only had Supreme and slimefun, it was a test server that I created to prove it

alvarophylipe commented 5 months ago

I've seen this same bug on several servers I joined. I contacted the administrators, and they didn't know how to proceed since the plugin hasn't been updated for a while. I decided to open a server with Slimefun and Supreme to test it, and I followed the exact steps described by @davidcanas. I was able to replicate the bug, and it affects all items that can be renamed in the anvil.

https://github.com/Slimefun-Addon-Community/Supreme/assets/87195703/17bb2043-b77e-40d1-8839-e7e98a8fd5c8

:D.

davidcanas commented 5 months ago

Tysm, for your testimony, Álvaro Phylipe \:D

Best regards, rest of a good weekend. ✨

lukariosmen commented 5 months ago

I made a temporary fix using the Minecraft plugin Skript. It's not perfect, but it blocks the ability to take items from the GUI.

Code:

on inventory click:
    if inventory name contains "&bElectric Magical Machine" or "&bElectric Core Machine" or "&bElectric Gear Machine" or "&bElectric Crafter":
        if event-inventoryaction is collect to cursor:
            cancel the event
        if event-inventoryaction is swap with hotbar:
            cancel the event
        if slot 44 of event-inventory is dark gray stained glass pane:
            if "%slot 23 of event-inventory%" doesn't contain "&cInput a valid material to start":
                if event-slot is not 25:
                    cancel the event

Needed plugins: Skript - https://github.com/SkriptLang/Skript SkQuery - https://github.com/SkQuery/SkQuery

If you need help or have found a way to bypass this, contact me on Discord: lukariosmen.

davidcanas commented 5 months ago

I really appreciate your help, @lukariosmen TYSM :D

RelativoBR commented 3 days ago

Correction related to this PR (https://github.com/Slimefun-Addon-Community/Supreme/pull/70)

scorninpc commented 1 day ago

I can confirm that #70 works like a charm. Thank you

Slimefun-Addon-Community / Supreme