added custom texture support for everything but heads

Kevin-writes-code commented 8 months ago

Description

Minecraft supports custom Textures for items since 1.14 and I thought it would be a great addition to allow TexturePack creators to add custom textures to ingots, items and so on.

Proposed changes

I added added customModelData to each items Metadata during registration, excluding heads since that'd break their textures. I also added a setter for the counter so add-ons can claim their own range for compatibility. Furthermore, and here I am a little uncertain, I had to change a line in customTextureService to not reset the customModelData. The provided Tests all passed and I am currently testing the changes on a private server. The variable customModelData could be used to get item-ids in guide.

Related Issues (if applicable)

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them. (For the ones I tested the customModelData increased as expected, the Items seem to behave as expected)
[x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.). (CustomModelData seems to have been added in 1.14)
[x] I followed the existing code standards and didn't mess up the formatting.
[x] I did my best to add documentation to any public classes or methods I added.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

github-actions[bot] commented 8 months ago

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️ Branch naming convention	Label
`feature/**`	🎈 Feature
`fix/**`	✨ Fix
`chore/**`	🧹 Chores
`api/**`	🔧 API
`performance/**`	💡 Performance Optimization
`compatibility/**`	🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

ybw0014 commented 8 months ago

We have item-models.yml, and some resource packs are already using this file.

Slimefun / Slimefun4