Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.
GNU General Public License v3.0
972 stars 544 forks source link

Fix backpack IDs not incrementing #4081

Closed WalshyDev closed 10 months ago

WalshyDev commented 10 months ago

Description

Fixes backpack IDs not incrementing unless the server is closed.

Proposed changes

The ID increment code was still reading the config file, updated this to rely on PlayerData. Made the next ID now be the backpack size. Created a new test to validate behaviour.

Related Issues (if applicable)

Fixes #4080

Checklist

github-actions[bot] commented 10 months ago

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 10 months ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 1953aa09

https://preview-builds.walshy.dev/download/Slimefun/4081/1953aa09

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!