Closed WalshyDev closed 10 months ago
Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️
The SonarCloud Quality Gate passed, but some issues were introduced.
9 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code
A Slimefun preview build is available for testing! Commit: 1953aa09
https://preview-builds.walshy.dev/download/Slimefun/4081/1953aa09
Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!
Description
Fixes backpack IDs not incrementing unless the server is closed.
Proposed changes
The ID increment code was still reading the config file, updated this to rely on PlayerData. Made the next ID now be the backpack size. Created a new test to validate behaviour.
Related Issues (if applicable)
Fixes #4080
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values