Fixes guide search when using colored chat

WalshyDev commented 6 months ago

Description

Proposed changes

With https://github.com/baked-libs/dough/pull/250 handle the ChatInput as colored text rather than user friendly (&) text.

Also pinned Spigot to resolve build issues.

Related Issues (if applicable)

N/A

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
[x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.).
[ ] I followed the existing code standards and didn't mess up the formatting.
[ ] I did my best to add documentation to any public classes or methods I added.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

TODO

[x] merge dough PR and update pom

github-actions[bot] commented 6 months ago

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

JustAHuman-xD commented 6 months ago

The color search was fixed here was it not? https://github.com/Slimefun/Slimefun4/pull/4044

WalshyDev commented 6 months ago

The color search was fixed here was it not? #4044

It was not. We aren't getting through real colored text so stripping wasn't actually doing anything. We're instead getting user friendly colored text (& - e.g. &6test)

So, we're changing to pass through real colored text and strip.

JustAHuman-xD commented 6 months ago

The color search was fixed here was it not? #4044

It was not. We aren't getting through real colored text so stripping wasn't actually doing anything. We're instead getting user friendly colored text (& - e.g. &6test)

So, we're changing to pass through real colored text and strip.

Okay that makes sense on the dough end, but what I didn't understand is why are you adding an additional strip color to the method parameter, it will call it already in the method

WalshyDev commented 6 months ago

Simple answer is I didn't see it getting stripped anywhere

JustAHuman-xD commented 6 months ago

Simple answer is I didn't see it getting stripped anywhere

Fair enough, it gets stripped in the survival slimefun guides implementation

WalshyDev commented 6 months ago

Yee I see it now, we call the interface method but in the same class is the impl func where we strip

This PR is basically just gonna be update dough then

sonarcloud[bot] commented 6 months ago

Quality Gate passed

Issues
4 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot] commented 6 months ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 0f9938e1

https://preview-builds.walshy.dev/download/Slimefun/4125/0f9938e1

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

Slimefun / Slimefun4