chore: add rc warnings to `sf versions` command

ybw0014 commented 8 months ago

Description

People who use RC versions still report bugs to Discord/GitHub, adding warning messages may possibily stop them from reporting. (just possible, people without eyes will still report) Also fixed a issue introduced in https://github.com/Slimefun/Slimefun4/pull/4096, where all the text after updater available have hover event.

This will only apply to future RC versions.

Test run (I changed the version manually to RC - 38, and this is only screenshot for first run):

Proposed changes

Add warning messages to /sf versions.

Related Issues (if applicable)

N/A

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
[ ] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.).
[x] I followed the existing code standards and didn't mess up the formatting.
[ ] I did my best to add documentation to any public classes or methods I added.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

github-actions[bot] commented 8 months ago

Your Pull Request was automatically labelled as: "🧹 Chores" Thank you for contributing to this project! ❤️

github-actions[bot] commented 8 months ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 26d7b086

https://preview-builds.walshy.dev/download/Slimefun/4129/26d7b086

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

ybw0014 commented 8 months ago

Where else we can add warning messages? maybe the version in sf guide?

JustAHuman-xD commented 8 months ago

I think we should re-word this, “we don’t provide support for stable versions” won’t make sense to 99% of people if they don’t know RC is meant for plugin developers.

J3fftw1 commented 8 months ago

Where else we can add warning messages? maybe the version in sf guide?

on the guide settings for players maybe.

Im in general not a huge fan of giving a warning. reports for RC should always be treated with a grain of salt since it can be fixed in dev versions as we see 99% of the time. But we have gotten valid reports on stable versions. Im not gonna put a blocker on it since i know many like this

ybw0014 commented 8 months ago

if you don't want such messages I will turn this into a bug fix PR.

Slimefun / Slimefun4