Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.
GNU General Public License v3.0
958 stars 547 forks source link

Item dupe with backpacks and a big player profile #4130

Closed TwinkleToes777 closed 6 months ago

TwinkleToes777 commented 6 months ago

❗ Checklist

📍 Description

An item dupe bug that can be done by opening backpack that was given by another player who has a huge player file (10.1MB), with hundreds of backpacks (599 to be exact)

📑 Reproduction Steps

Step 0: Restart server, ensures that other player's backpacks will be unloaded prior to starting the dupe process Step 1: Open up a backpack of a person who has made a ton of backpacks with possibly a ton of items in them Step 2: Server lags, after which the backpack will open Step 3: Take items out of the backpack somewhat quickly, then close the interface or wait for it to refresh on its own Step 4: Open the backpack again, which opens instantly without any lag assuming the interface was closed Step 5: The original items that were taken out are both still in the backpack and your inventory, which means that the items were duped

💡 Expected Behavior

I expected items to not get duped

📷 Screenshots / Videos

No response

📜 Server Log

No response

📂 /error-reports/ folder

No response

💻 Server Software

Purpur

🎮 Minecraft Version

1.19.x

⭐ Slimefun version

This Server uses the following setup of Slimefun: Purpur git-Purpur-1985 (MC: 1.19.4) Slimefun Dev - 1136 Metrics-Module #29 Java 17 Installed Addons: (8) Networks vDEV - 50 (git 3de3c9d6) InfinityExpansion vDEV - 144 (git 9da37202) SFCalc vDev - 38 MobCapturer vDEV - 33 (git 6fc26c35) HotbarPets vDEV - 38 (git fa6c871d) EcoPower vDEV - 5 (git 5c1ecd68) FluffyMachines vDEV - 132 (git ccf029ba) ExoticGarden vDEV - 78 (git 7f9a5f63)

🧭 Other plugins

No response

Boomer-1 commented 6 months ago

there were some fixes today that could possibly stop this, as you had reported a lag issue. once that new dev version rolls out, please retest on the newer dev version

J3fftw1 commented 6 months ago

They are on the new build

Boomer-1 commented 6 months ago

didn't think it had reached blob.builds yet, thanks

J3fftw1 commented 6 months ago

I can repro this bug very conisitently now.