Optimize SlimefunUtils#isItemSimilar / Optimize SlimefunUtils#equalsItemMeta

IAISI commented 6 months ago

Optimize SlimefunUtils#isItemSimilar Optimize SlimefunUtils#equalsItemMeta

Description

We can skip some of slow ItemMeta checks that relay on getDisplayName() and getLore() which both deserialize string from JSON internally in Spigot

Proposed changes

We check SF Item IDs first if those are available and then fallback to ItemMeta check.

Related Issues (if applicable)

Checklist

[ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
[x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.).
[x] I followed the existing code standards and didn't mess up the formatting.
[ ] I did my best to add documentation to any public classes or methods I added.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

github-actions[bot] commented 6 months ago

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️ Branch naming convention	Label
`feature/**`	🎈 Feature
`fix/**`	✨ Fix
`chore/**`	🧹 Chores
`api/**`	🔧 API
`performance/**`	💡 Performance Optimization
`compatibility/**`	🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

J3fftw1 commented 6 months ago

We have another PR changing this already as said many times on discord. https://github.com/Slimefun/Slimefun4/pull/4120

IAISI commented 6 months ago

The https://github.com/Slimefun/Slimefun4/pull/4120 doesn't remove those functions from SlimeFunUtils class tho? If so it's possible they would still be used? By other addons and stuff that is not related to Cargo?

WalshyDev commented 6 months ago

We cannot just remove public API without a deprecation period. The PR deprecates them as is our policy. That PR changes all Slimefun usages of the functions including Cargo.

They will be removed after the next RC when it's merged.

IAISI commented 6 months ago

Sounds good, I guess I can just close this?

J3fftw1 commented 6 months ago

Closed in favour of #4120

Slimefun / Slimefun4