Open ybw0014 opened 6 months ago
Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️ Branch naming convention | Label |
---|---|
feature/** |
🎈 Feature |
fix/** |
✨ Fix |
chore/** |
🧹 Chores |
api/** |
🔧 API |
performance/** |
💡 Performance Optimization |
compatibility/** |
🤝 Compatibility |
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀
A Slimefun preview build is available for testing! Commit: 08574465
https://preview-builds.walshy.dev/download/Slimefun/4158/08574465
Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!
What's the use case for the PDC here?
For my addon SlimefunTranslation. Slimefun's localization only covers Slimefun's ItemGroups, it is a bit annoying to add localization for addons' ItemGroups. (unless I missed something)
Description
ItemGroup items can be arbitrary. A Slimefun item, a simple renamed vanilla item, or a complex item can be an ItemGroup item. It would be good if they could have their
NamespacedKey
in their PDC so other plugins can read this as an ItemGroup item.Proposed changes
ItemGroup items now have
slimefun:item_group
in their PDC.Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values