github-actions[bot]
commented
5 months ago | Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️ Branch naming convention | Label |
|---|---|
feature/** |
🎈 Feature |
fix/** |
✨ Fix |
chore/** |
🧹 Chores |
api/** |
🔧 API |
performance/** |
💡 Performance Optimization |
compatibility/** |
🤝 Compatibility |
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀
J3fftw1
Violet-Nonbloosom
Description
In TP time calculation, $\rm complexity \times complexity$ may result in int overflow when complexity is higher than $4\times 10^{4}$, not difficult to achieve with several popular addons.
Compared with original solution based on
Mathfunction, it is better to avoid overflow directly.Proposed changes
Use
longto storage temporary speed variable, which hardly overflow in TP time calculation.If $\rm speed > distance$, time cost must be 1 tick, so we can skip calculation.
Otherwise, $\rm \dfrac {distance}{speed} \geq 1$, while speed must be in range of
int.Therefore we can simply convert speed to int variable to calculate ultimate time cost.
Related Issues (if applicable)
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values