Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.
GNU General Public License v3.0
943 stars 536 forks source link

Writtenbook soulbound fix #4169

Open ShiftSad opened 3 months ago

ShiftSad commented 3 months ago

Description

When cloning an Written Book in the crafting slot with a Writable Book, it keeps all the item data, like the SoulBound Status. With should not be intended since it "dupes it".

Proposed changes

Simply setting the soul bound status false when a book is cloned

Related Issues (if applicable)

Checklist

github-actions[bot] commented 3 months ago
Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️ Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

ShiftSad commented 3 months ago

This is my first pull request, if there is anything I can improve I would be glad to do so. I have already noticed the labels, next time I'll make sure to use them.

github-actions[bot] commented 3 months ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: ccc9c4c5

https://preview-builds.walshy.dev/download/Slimefun/4169/ccc9c4c5

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!