Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.

GNU General Public License v3.0

964 stars 547 forks source link

fix AContainer can't find recipes with similar items #4177

Open JWJUN233233 opened 5 months ago

JWJUN233233 commented 5 months ago

Description

4166

Proposed changes

Related Issues (if applicable)

4166

Checklist

[ ] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[ ] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
[x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.).
[x] I followed the existing code standards and didn't mess up the formatting.
[x] I did my best to add documentation to any public classes or methods I added.
[x] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

github-actions[bot] commented 5 months ago

Your Pull Request was automatically labelled as: "✨ Fix" Thank you for contributing to this project! ❤️

JustAHuman-xD commented 5 months ago

Can you update the PR to be inline with the code style guidelines

JWJUN233233 commented 5 months ago

i wonder whats wrong with my codestyle

Intybyte commented 5 months ago

i wonder whats wrong with my codestyle

Don't use wildcard(*) imports. Don't use functional methods like .stream() or .foreach( x -> ...), just use a normal for loop. Saving x and y Inputs in a variable would help with readibility.

J3fftw1 commented 5 months ago

Variables need to be camel_Case

github-actions[bot] commented 5 months ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 505b4442

https://preview-builds.walshy.dev/download/Slimefun/4177/505b4442

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

J3fftw1 commented 5 months ago

Thanks for the first PR we really appreciate it.

JustAHuman-xD commented 5 months ago

Don't we have an item utils already or something like it?

JWJUN233233 commented 5 months ago

Don't we have an item utils already or something like it?

It seems not

lijinhong11 commented 5 months ago

bump