Added TestSoundService - Githubissues

Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.

GNU General Public License v3.0

943 stars 536 forks source link

Added TestSoundService #4180

Open Intybyte opened 2 months ago

Intybyte commented 2 months ago

Description

Unit tests for new sound system

Proposed changes

Adding unitest

Related Issues (if applicable)

Resolves #3881, #2844, #3880

Checklist

[x] I have fully tested the proposed changes and promise that they will not break everything into chaos.
[x] I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
[x] I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16. - 1.20.).
[x] I followed the existing code standards and didn't mess up the formatting.
[ ] I did my best to add documentation to any public classes or methods I added.
[ ] I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
[ ] I added sufficient Unit Tests to cover my code.

github-actions[bot] commented 2 months ago

Pro Tip! You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️ Branch naming convention	Label
`feature/**`	🎈 Feature
`fix/**`	✨ Fix
`chore/**`	🧹 Chores
`api/**`	🔧 API
`performance/**`	💡 Performance Optimization
`compatibility/**`	🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

J3fftw1 commented 2 months ago

Thanks for your first PR thank you for reviewing it.

J3fftw1 commented 2 months ago

Does this cover all of the soundservice?

github-actions[bot] commented 2 months ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 03aa31c8

https://preview-builds.walshy.dev/download/Slimefun/4180/03aa31c8

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!

Intybyte commented 2 months ago

Does this cover all of the soundservice?

It should, I get all the element in theSoundEffect enum and check if it has a configuration using the SoundService, as it might be null even if it should not.

In fact the SoundEffect enum has a method that gets the SoundService instance in order to check it, which before returning the value checks if it is null, and prints a warning (the comment itself says that this should not happen in the first place), so by adding this test you are checking all of the elements of SoundEffect ahead in the testing.

It is complete unless the reload method requires some testing too.