Open Intybyte opened 2 months ago
Your Pull Request was automatically labelled as: "🎈 Feature" Thank you for contributing to this project! ❤️
We previously denied a PR like this since it’s in one of the addons already I think
Oh really? Anyone know what addon?
We previously denied a PR like this since it’s in one of the addons already I think
Just because an addon adds it it isn't a good reason to not accept the PR man, someone a day made a mod for pistons in minecraft back in beta and mojang decided to add it to the main game. Never saw anyone whining about pistons xD
As a general rule, core slimefun doesn't add items that addons have for obvious reasons. it's not to say it wouldn't happen, but it doesn't make sense to duplicate others work
Can anyone say what addon this is in? If it's abandoned or unmaintained, something like that, I think that'd be justification enough for it being added to core slimefun.
i've not seen one that i can remember. i just checked the active addons and it's not there. the only other juicer i've seen is in fast machines
A Slimefun preview build is available for testing! Commit: 66d8b392
https://preview-builds.walshy.dev/download/Slimefun/4191/66d8b392
Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!
Approved suggestion #2560 discord
Description
Adding an ElectricJuicer so people aren't force to use the manual MultiBlock to get juicer, and can automate the process with cargo.
Proposed changes
Added on PostSetup a juicer recipe loader to a new machine called ElectricJuicer. The new recipe is similar to the original multiblock, but requiring some electric motors, a battery and some other basic blocks.
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values