Slimefun / Slimefun4

Slimefun 4 - A unique Spigot/Paper plugin that looks and feels like a modpack. We've been giving you backpacks, jetpacks, reactors and much more since 2013.
GNU General Public License v3.0
943 stars 536 forks source link

ElectricJuicer #4191

Open Intybyte opened 2 months ago

Intybyte commented 2 months ago

Approved suggestion #2560 discord

Description

Adding an ElectricJuicer so people aren't force to use the manual MultiBlock to get juicer, and can automate the process with cargo.

Proposed changes

Added on PostSetup a juicer recipe loader to a new machine called ElectricJuicer. The new recipe is similar to the original multiblock, but requiring some electric motors, a battery and some other basic blocks.

Checklist

github-actions[bot] commented 2 months ago

Your Pull Request was automatically labelled as: "🎈 Feature" Thank you for contributing to this project! ❤️

J3fftw1 commented 2 months ago

We previously denied a PR like this since it’s in one of the addons already I think

JustAHuman-xD commented 2 months ago

Oh really? Anyone know what addon?

Intybyte commented 2 months ago

We previously denied a PR like this since it’s in one of the addons already I think

Just because an addon adds it it isn't a good reason to not accept the PR man, someone a day made a mod for pistons in minecraft back in beta and mojang decided to add it to the main game. Never saw anyone whining about pistons xD

Boomer-1 commented 2 months ago

As a general rule, core slimefun doesn't add items that addons have for obvious reasons. it's not to say it wouldn't happen, but it doesn't make sense to duplicate others work

JustAHuman-xD commented 1 month ago

Can anyone say what addon this is in? If it's abandoned or unmaintained, something like that, I think that'd be justification enough for it being added to core slimefun.

Boomer-1 commented 1 month ago

i've not seen one that i can remember. i just checked the active addons and it's not there. the only other juicer i've seen is in fast machines

github-actions[bot] commented 1 month ago

Slimefun preview build

A Slimefun preview build is available for testing! Commit: 66d8b392

https://preview-builds.walshy.dev/download/Slimefun/4191/66d8b392

Note: This is not a supported build and is only here for the purposes of testing. Do not run this on a live server and do not report bugs anywhere but this PR!